oamg / leapp-repository

Leapp repositories containing actors for the Leapp framework (https://github.com/oamg/leapp). Currently provides leapp repositories for in-place upgrades of RHEL systems.
Apache License 2.0
48 stars 144 forks source link

Improve set_systemd_services_states logging #1213

Closed evgeni closed 1 month ago

evgeni commented 4 months ago
  1. demotes the "both enable and disable" message to a warning, as it's not an error
  2. doesn't try to enable services that will be disabled afterwards, limiting the amount of logged commands
github-actions[bot] commented 4 months ago

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable. If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. If you need a different version of leapp, e.g. from PR#42, use /packit test oamg/leapp#42 Note that first time contributors cannot run tests automatically - they will be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones. To launch on-demand tests with packit:

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

matejmatuska commented 2 months ago

/packit copr-build

matejmatuska commented 2 months ago

/packit copr-build

matejmatuska commented 2 months ago

/packit retest-failed

pirat89 commented 2 months ago

@evgeni @matejmatuska it's possible you need to rebase to make AWS passing again due to changes in tests.

evgeni commented 2 months ago

Rebased

pirat89 commented 2 months ago

/packit copr-build

matejmatuska commented 1 month ago

/packit retest-failed

matejmatuska commented 1 month ago

@evgeni Please rebase, the tests should be fixed now.

evgeni commented 1 month ago

Feel free to do so yourself (you should have access to my fork). I am away from my ssh keys.

evgeni commented 1 month ago

It's green! Quick, merge it before things turn red again :)