search

oamg / leapp-repository

Leapp repositories containing actors for the Leapp framework (https://github.com/oamg/leapp). Currently provides leapp repositories for in-place upgrades of RHEL systems.
Apache License 2.0
48 stars 144 forks source link

storage initialisation: apply sleep always #1219

Closed pirat89 closed 3 months ago

pirat89 commented 3 months ago

Based on feedback from @rmetrich¹ the sleep period should be applied always as the problem with initialisation is happening also on systems with higher than few number of LVs where /usr is not on dedicated volume.

1: https://github.com/oamg/leapp-repository/pull/1218#issuecomment-2093303020

Note: wait for @rmetrich answer before merging to be sure that this is really not covered by the lvm activation check.

jira: https://issues.redhat.com/browse/RHEL-3344

github-actions[bot] commented 3 months ago

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable. If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. If you need a different version of leapp, e.g. from PR#42, use /packit test oamg/leapp#42 Note that first time contributors cannot run tests automatically - they will be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones. To launch on-demand tests with packit:

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

pirat89 commented 3 months ago

/packit restest-failed

pirat89 commented 3 months ago

Failed el8 tests are not related to the change in this PR. it's mid-time known infrastructure issue and it's not clear why it's happening.

pirat89 commented 3 months ago

/packit retest-failed

pirat89 commented 3 months ago

/packit copr-build

pirat89 commented 3 months ago

@oamg/developers note I rerun the tests, however realized some additional issues with the CI (with ondemand tests) that are not related to changes in this PR. Let's merge it and keep the CI troubles on other PRs.