search

oamg / leapp-repository

Leapp repositories containing actors for the Leapp framework (https://github.com/oamg/leapp). Currently provides leapp repositories for in-place upgrades of RHEL systems.
Apache License 2.0
48 stars 144 forks source link

Update PR bot welcome msg #1220

Closed pirat89 closed 2 months ago

pirat89 commented 3 months ago

I found useful to be able to run just failed tests (when they crashed due to infrastructure issues). Updating the welcome msg to provide this info and little bit restructured original statement, to make it more friendly for reading. I've updated the bot msg below manually to show the expected content.

github-actions[bot] commented 3 months ago

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable. If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. However, here are additional useful commands for packit:

Note that first time contributors cannot run tests automatically - they need to be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones. To launch on-demand tests with packit:

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

pirat89 commented 3 months ago

@oamg/developers note that /packit retest-failed command is not buggy: https://github.com/packit/packit-service/issues/1886 - so I can think about dropping it for now from the msg. but it's possibly it will be fixed during next month. wdyt? keep it or drop it and put it back once it's fixed?

r0x0d commented 3 months ago

@pirat89, why not using dependabot or renovate to keep the dependencies up-to-date? With renovate, you can have more configurable settings for how many PRs it will open in a give period, I believe.

pirat89 commented 3 months ago

@r0x0d well, we can take a look. I am not so familiar with it, but original approach to use dependabot in the project was to automatically inform about newer python packages available (when installing by pip to run unit-tests) and basically we didn't want any info about newer python apps available. if we can use it to track just particular deps, I think it could be potentially useful in future.

r0x0d commented 3 months ago

@r0x0d well, we can take a look. I am not so familiar with it, but original approach to use dependabot in the project was to automatically inform about newer python packages available (when installing by pip to run unit-tests) and basically we didn't want any info about newer python apps available. if we can use it to track just particular deps, I think it could be potentially useful in future.

I will look into setting up renovate for leapp-repository. I will message you in slack to check which type of deps you want to get info.

evgeni commented 3 months ago

@r0x0d well, we can take a look. I am not so familiar with it, but original approach to use dependabot in the project was to automatically inform about newer python packages available (when installing by pip to run unit-tests) and basically we didn't want any info about newer python apps available. if we can use it to track just particular deps, I think it could be potentially useful in future.

dependabot can be configured to look at certain "ecosystems"/"package managers" only, so bump actions but not python, etc.

https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#example-of-a-basic-setup-for-three-package-managers

r0x0d commented 3 months ago

Created https://github.com/oamg/leapp-repository/pull/1221

matejmatuska commented 2 months ago

@pirat89 I know #1221 is already merged, just one thing to keep in mind is that when a GH Action is updated, we have to change the allowed version in repository setting too. That's what broke the pr-welcome-message-bot and shellcheck.