Closed pirat89 closed 3 months ago
Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable. If you want to request a review or rebuild a package in copr, you can use following commands as a comment:
Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. If you need a different version of leapp, e.g. from PR#42, use /packit test oamg/leapp#42
Note that first time contributors cannot run tests automatically - they will be started by a reviewer.
It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal
and kernel-rt
, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:
kernel-rt
tests set for all upgrade pathskernel-rt
and beaker-minimal
test sets for 8.10->9.4 upgrade pathSee other labels for particular jobs defined in the .packit.yaml
file.
Please open ticket in case you experience technical problem with the CI. (RH internal only)
Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.
Issues:
Note that in case of checktargetrepos actor we are introducing
https://red.ht/upgrading-rhel9-to-rhel10-main-official-doc
for IPU 9 -> 10. However, this shortened URL must be defined yet later. The doc does not exist yet, so no rush. I've added the URL to our list of used shortened URLs, marked as broken, so it's visible.In case of
W0135
, linters expects try-finally right aroundyield
. Checked reported context managers, usually it's FP as it doesn't take into acount:yield
(seeoverlaygen.py:create_source_overlay()
)which in such a case the try-final is handled by the nested
another_context_mgr
, which is the typical scenario in reported warnings.