Closed evgeni closed 3 months ago
@evgeni lgtm. I like it. But thinking about that, when you already started these changes, that we could add also remediation instructions, somthing like:
pkg_manager = 'yum' if version.get_source_major_version == '7' else 'dnf
reporting.Remediation(hint=(
'Update your system using {pkg_manager} to the version of the system supported for the in-place upgrade.'
.format(pkg_manager=pkg_manager)
))
Personally, I wouldn't do that.
The unsupported systems will be Alma, Rocky etc, and they can't be upgraded using dnf
, so posting that remediation would be wrong
Interesting. Oki, let's skip it for now. It can be added later, e.g. with the check the system is rhel
.
Maybe the "will" was too hard, but certainly "could" until we allow them properly.
well, when we add check for the rhel
system, then we can clearly skip this whole report from my pov. e.g. for centos stream this report does not provide any value at all. and I have no idea about requirements from almalinux/rocky at all. so from my pov, it's matter of time we update this particular actor. but it's for me interesting that almalinux could not use yum/dnf for the update of the system. that's for me hoenstly little bit weird. so I guess I am missing here something.
Can you use yum/dnf to upgrade RHEL from 8 to 9? Alma/Rocky/Oracle has the same issue. You gotta Leapp major versions.
no, but you can use DNF do update to newer minor version. This is about trying to upgrade FROM unsupported version of the system.
Ooooh. Now I get what you wanted to do!
if (on 8.9) {
tell user to update to 8.10 first using dnf
}
I've read it as "we do not support this OS, use dnf for the major upgrade instead"
Damn, I should read less comments on tiny smartphone screen.
includes #1234 to prevent merge conflicts