search

oamg / leapp-repository

Leapp repositories containing actors for the Leapp framework (https://github.com/oamg/leapp). Currently provides leapp repositories for in-place upgrades of RHEL systems.
Apache License 2.0
48 stars 144 forks source link

Fix IPU being blocked by resource limitations #1256

Open tomasfratrik opened 2 months ago

tomasfratrik commented 2 months ago

First resource limit is maximum number of open file descriptors limit, second one being limit for maximum writable file size.

With resource lib we set the limit for the current process (tested with my testing scripts) and its children processes. By testing pre-upgrade and upgrade I found a threshold of max. open file descriptors to be around 512, (the default value for ulimit -n is 1024) so a small multiplier of the default value shouldn't be a problem to set. With writing size there shouldn't be a problem to set it to "infinity".

Both problems from the tickets were solved, but there could be other side effects.

Resolves: RHEL-26459 and RHEL-16881

github-actions[bot] commented 2 months ago

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable. If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. However, here are additional useful commands for packit:

Note that first time contributors cannot run tests automatically - they need to be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones. To launch on-demand tests with packit:

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

matejmatuska commented 2 months ago

/packit copr-build

fernflower commented 2 months ago

/packit test

tomasfratrik commented 1 month ago

I don't really like the redundancy of code here, but I'm not sure where should the common logic be placed.

matejmatuska commented 1 month ago

I don't really like the redundancy of code here, but I'm not sure where should the common logic be placed.

I think commands/command_utils.py is an option. There is already some code the commands share.

matejmatuska commented 1 month ago

/packit retest-failed

tomasfratrik commented 1 month ago

I don't really like the redundancy of code here, but I'm not sure where should the common logic be placed.

I think commands/command_utils.py is an option. There is already some code the commands share.

Thanks, I put it there

pirat89 commented 1 month ago

/packit copr-build

pirat89 commented 1 month ago

all standard tests passed. executing extended tests

pirat89 commented 1 month ago

/packit test

pirat89 commented 1 month ago

ah.. I thought it's different PR :D mama mia!