Open tomasfratrik opened 2 months ago
Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable. If you want to request a review or rebuild a package in copr, you can use following commands as a comment:
review please @oamg/developers
to notify leapp developers of the review request/packit copr-build
to submit a public copr build using packitPackit will automatically schedule regression tests for this PR's build and latest upstream leapp build. However, here are additional useful commands for packit:
/packit test
to re-run manually the default tests/packit retest-failed
to re-run failed tests manually/packit test oamg/leapp#42
to run tests with leapp builds for the leapp PR#42 (default is latest upstream - master - build)Note that first time contributors cannot run tests automatically - they need to be started by a reviewer.
It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal
and kernel-rt
, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:
/packit test --labels kernel-rt
to schedule kernel-rt
tests set for all upgrade paths/packit test --labels beaker-minimal-8.10to9.4,kernel-rt-8.10to9.4
to schedule kernel-rt
and beaker-minimal
test sets for 8.10->9.4 upgrade pathSee other labels for particular jobs defined in the .packit.yaml
file.
Please open ticket in case you experience technical problem with the CI. (RH internal only)
Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.
/packit copr-build
/packit test
I don't really like the redundancy of code here, but I'm not sure where should the common logic be placed.
I don't really like the redundancy of code here, but I'm not sure where should the common logic be placed.
I think commands/command_utils.py
is an option. There is already some code the commands share.
/packit retest-failed
I don't really like the redundancy of code here, but I'm not sure where should the common logic be placed.
I think
commands/command_utils.py
is an option. There is already some code the commands share.
Thanks, I put it there
/packit copr-build
all standard tests passed. executing extended tests
/packit test
ah.. I thought it's different PR :D mama mia!
First resource limit is maximum number of open file descriptors limit, second one being limit for maximum writable file size.
With resource lib we set the limit for the current process (tested with my testing scripts) and its children processes. By testing pre-upgrade and upgrade I found a threshold of max. open file descriptors to be around 512, (the default value for ulimit -n is 1024) so a small multiplier of the default value shouldn't be a problem to set. With writing size there shouldn't be a problem to set it to "infinity".
Both problems from the tickets were solved, but there could be other side effects.
Resolves: RHEL-26459 and RHEL-16881