oamg / leapp-repository

Leapp repositories containing actors for the Leapp framework (https://github.com/oamg/leapp). Currently provides leapp repositories for in-place upgrades of RHEL systems.
Apache License 2.0
48 stars 144 forks source link

Fix storage scanner parsing error #1258

Open tomasfratrik opened 1 month ago

tomasfratrik commented 1 month ago

The given error arises when storage scanner actor attempts to parse output from command pvs while output containts separator symbol within itself. Changed the format of physical volume as was suggested in the ticket so it contains separator :, and was given following error while preupgrade and upgrade. (e.g: format of physical volume, contains the symbol : `/dev/disk/by-path/pci-0000:00:03.0-part2)

  File "/etc/leapp/repos.d/system_upgrade/common/actors/storagescanner/libraries/storagescanner.py", line 195, in _get_pvs_info
    pv, vg, fmt, attr, psize, pfree = entry
ValueError: too many values to unpack (expected 6)

Therefore changing the separation symbol to |, and running preupgrade and upgrade from RHEL8 to RHEL9 didn't raise any errors.

Jira: RHEL-34570

github-actions[bot] commented 1 month ago

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable. If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. However, here are additional useful commands for packit:

Note that first time contributors cannot run tests automatically - they need to be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones. To launch on-demand tests with packit:

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

pirat89 commented 1 month ago

@tomasfratrik rebase against master. tests should be fixed now

matejmatuska commented 1 month ago

/packit retest-failed

tomasfratrik commented 1 month ago

/packit retest-failed

matejmatuska commented 3 weeks ago

/packit retest-failed

matejmatuska commented 2 weeks ago

@tomasfratrik Works as expected now, please squash the commits and I can approve this.

tomasfratrik commented 1 week ago

The latest push squashes commits.