oamg / leapp-repository

Leapp repositories containing actors for the Leapp framework (https://github.com/oamg/leapp). Currently provides leapp repositories for in-place upgrades of RHEL systems.
Apache License 2.0
48 stars 144 forks source link

GPG check: do not raise an error when TargetUserSpaceInfo is missing #1262

Closed pirat89 closed 1 month ago

pirat89 commented 1 month ago

Previously, if the upgrade has been inhibited during TargetTransactionFactsCollectionPhase usually because we could not create (for whatever reason) the target userspace container, the actor checking rpm gpg keys failed with the Could not check for valid GPG keys error. This has confused many users as they couldn't know that this is impacted by the problem described in an inhibitor that is below this error.

As it's for sure that the upgrade cannot continue when the target user space container has not been created (the TargetUserSpaceInfo msg is missing), we consider it safe to stop the gpg check here silently just with a warning msg instead of raising the error - as this check is important only in case we could actually upgrade.

All other possible raised errors are presereved.

jira: https://issues.redhat.com/browse/RHEL-30573

github-actions[bot] commented 1 month ago

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable. If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. However, here are additional useful commands for packit:

Note that first time contributors cannot run tests automatically - they need to be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones. To launch on-demand tests with packit:

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

matejmatuska commented 1 month ago

/packit copr-build

Jakuje commented 1 month ago

Closed in favor of #1269, which fixed the test failures in here.

Rezney commented 1 month ago

Closing in favor of https://github.com/oamg/leapp-repository/pull/1269 as we could not push to the branch.