search

oamg / leapp-repository

Leapp repositories containing actors for the Leapp framework (https://github.com/oamg/leapp). Currently provides leapp repositories for in-place upgrades of RHEL systems.
Apache License 2.0
52 stars 146 forks source link

rhui setups support alibaba cloud for arm64 #1277

Closed jinkkkang closed 2 months ago

jinkkkang commented 2 months ago

rhui(alibaba): add ARM RHEL8 and RHEL9 setup entries

Since leapp's RHUI mechanism filters setups based on the architecture of the source system, it was not possible to upgrade of ARM-based RHEL systems on Alibaba cloud as there were no ARM entries in RHUI_SETUPS. This patch adds these entries, making it possible for 8>9 upgrades of ARM systems on Alibaba cloud.

related jira: https://issues.redhat.com/browse/RHEL-53181

github-actions[bot] commented 2 months ago

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable. If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. However, here are additional useful commands for packit:

Note that first time contributors cannot run tests automatically - they need to be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones. To launch on-demand tests with packit:

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

pirat89 commented 2 months ago

/packit copr-build

MichalHe commented 2 months ago

@jinkkkang Could you maybe provide a better commit message, please? Something like

rhui(alibaba): add ARM RHEL8 and RHEL9 setup entries

Since leapp's RHUI mechanism filters setups based on the architecture of the source system,
it was not possible to upgrade of ARM-based RHEL systems on Alibaba cloud as there
were no ARM entries in RHUI_SETUPS. This patch adds these entries, making it possible
for 8>9 upgrades of ARM systems on Alibaba cloud.
jinkkkang commented 2 months ago

ok, commit updated.

jinkkkang commented 2 months ago

Incorrect operation closed PR, it has been reopened, please merge it If there are no other issues @MichalHe

pirat89 commented 2 months ago

@jinkkkang that's unfortunate. I am now discussing whether we could make this PR to the upcoming release as you missed already the deadline for the changes. The closed PR slipped through our fingers. Also note that the commit is still not updated. But we will update the msg during the merge. Note that all PRs merged after friday are already going by default to May 2025 release.