oamg / leapp-repository

Leapp repositories containing actors for the Leapp framework (https://github.com/oamg/leapp). Currently provides leapp repositories for in-place upgrades of RHEL systems.
Apache License 2.0
48 stars 144 forks source link

"refactor" the targetuserspacecreator actor (and other related) #486

Open pirat89 opened 4 years ago

pirat89 commented 4 years ago

See the #482 PR. I have created bunch of TODOs with instructions (later will be added here). The current shape is really bad, but regarding the lack of time, I rather chose to skip such refactoring now and do it after the next release. The proper refactoring should take into account instruction in TODOs and should include properly written unit-tests covering the functionality properly (currently, unit tests cover just small part of the whole functionality). Affected actors and libraries:

Probably new check actor(s) could be created as well.

pirat89 commented 1 year ago

Relates to #973