oamg / leapp

Leapp - Application & OS Modernization Framework (For in-place upgrades, follow leapp-repository)
https://oamg.github.io/leapp/
Apache License 2.0
87 stars 70 forks source link

Update rhel7.9 compose #741

Closed fernflower closed 3 years ago

github-actions[bot] commented 3 years ago

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergable. If you want to re-run tests or request review, you can use following commands as a comment:

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

centos-ci commented 3 years ago

Can one of the admins verify this patch?

vinzenz commented 3 years ago

Wouldn't it make more sense to have these as an environment variable which we can set in the project configuration on GitHub?

fernflower commented 3 years ago

@vinzenz yeah, definitely. Will do tomorrow, thanks!

fernflower commented 3 years ago

Good news - with this compose the tests are fine https://api.dev.testing-farm.io/v0.1/requests/4d91e6bf-6261-4a7c-b9d3-9b1869f66f9b