oamg / leapp

Leapp - Application & OS Modernization Framework (For in-place upgrades, follow leapp-repository)
https://oamg.github.io/leapp/
Apache License 2.0
87 stars 70 forks source link

get_common_X_path functions into a library #742

Closed fernflower closed 2 years ago

fernflower commented 2 years ago

Those methods in actor/init.py have been static anyway, by moving them out not only we do the right thing, but make them accessible in non-actor libraries like command libraries.

github-actions[bot] commented 2 years ago

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergable. If you want to re-run tests or request review, you can use following commands as a comment:

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

centos-ci commented 2 years ago

Can one of the admins verify this patch?

fernflower commented 2 years ago

/rerun

github-actions[bot] commented 2 years ago

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/2982482

github-actions[bot] commented 2 years ago

Testing Farm request for tmt test was created. Once finished, results should be available here. Full pipeline log.

fernflower commented 2 years ago

/rerun

github-actions[bot] commented 2 years ago

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/2982566

github-actions[bot] commented 2 years ago

Testing Farm request for tmt test was created. Once finished, results should be available here. Full pipeline log.

fernflower commented 2 years ago

@vinzenz All resolved, thanks!

fernflower commented 2 years ago

/rerun

github-actions[bot] commented 2 years ago

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/2983528

github-actions[bot] commented 2 years ago

Testing Farm request for tmt test was created. Once finished, results should be available here. Full pipeline log.