Closed fernflower closed 2 years ago
Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergable. If you want to re-run tests or request review, you can use following commands as a comment:
Please open ticket in case you experience technical problem with the CI. (RH internal only)
Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.
Can one of the admins verify this patch?
/rerun
Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/2982482
Testing Farm request for tmt test was created. Once finished, results should be available here. Full pipeline log.
/rerun
Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/2982566
Testing Farm request for tmt test was created. Once finished, results should be available here. Full pipeline log.
@vinzenz All resolved, thanks!
/rerun
Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/2983528
Testing Farm request for tmt test was created. Once finished, results should be available here. Full pipeline log.
Those methods in actor/init.py have been static anyway, by moving them out not only we do the right thing, but make them accessible in non-actor libraries like command libraries.