Packit: stop merging with master for PRs builds

oamg / leapp

Leapp - Application & OS Modernization Framework (For in-place upgrades, follow leapp-repository)

https://oamg.github.io/leapp/

Apache License 2.0

87 stars 70 forks source link

Packit: stop merging with master for PRs builds #748

Closed pirat89 closed 2 years ago

pirat89 commented 2 years ago

When a PR build is created by PackIt it contains different hash of the commit than the latest in the PR. This is caused by the default behaviour, when PackIt merge locally the PR changes to the master.

As we like this idea to test stuff how it works when applied to the master, it has several problems:

sometimes a PR could have conflicts with master and the build will not be created in such a case; but for some simple testing it could be a little bit annoying for someone
it's not possible to install a build to a specific commit using the commit short-hash; sometimes it's usefull when you want to really try the build from specific commit and it's hard to find the right one in such a case

So let's set merge_pr_in_ci to false so the created build is identical to the one in the PR.

github-actions[bot] commented 2 years ago

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergable. If you want to re-run tests or request review, you can use following commands as a comment:

leapp-ci build to run copr build and e2e tests in OAMG CI
review please to notify leapp developers of review request
/packit copr-build to submit a public copr build using packit

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

centos-ci commented 2 years ago

Can one of the admins verify this patch?

pirat89 commented 2 years ago

Putting to the draft for not as current version of PackIt contains bug. When merge_pr_in_ci is false, the package schema is incorrect due to wrong local ref.

Expected: leapp-repository-0.15.0-0.20220106125723353413.pr790.39.g07a7000...
Current: leapp-repository-0.15.0-0.20220106125723353413.pr.changes790.39.g07a7000...

Reported issue: https://github.com/packit/packit/issues/1443 Thanks @TomasTomecek for fast investigation!

pirat89 commented 2 years ago

@vinzenz and this one too please! :)