Unify leapp-preupgrade and leapp-upgrade logs

oamg / leapp

Leapp - Application & OS Modernization Framework (For in-place upgrades, follow leapp-repository)

https://oamg.github.io/leapp/

Apache License 2.0

87 stars 70 forks source link

Unify leapp-preupgrade and leapp-upgrade logs #763

Closed fernflower closed 2 years ago

fernflower commented 2 years ago

Instead of having a dedicated leapp-CMDNAME file for each command log latest run as leapp.log.

github-actions[bot] commented 2 years ago

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergable. If you want to re-run tests or request review, you can use following commands as a comment:

leapp-ci build to run copr build and e2e tests in OAMG CI
review please to notify leapp developers of review request
/packit copr-build to submit a public copr build using packit

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

centos-ci commented 2 years ago

Can one of the admins verify this patch?

vinzenz commented 2 years ago

Well if you would do this now, this would mean you would have to update all the documentation. Also would this clash a bit with C2R - While I am pretty sure why you think we need this, I think there might be an alternative solution. I think it might work if you would set leapp.logger._logger to None after you're done.

fernflower commented 2 years ago

Well iiuc clash with convert2rhel is not something we have to worry about anymore, as they won't be using leapp for conversions. If we don't have doc freeze I'd rather have 1 log file, but maybe leapp.log is a very bad name, yeah. How about keeping leapp-upgrade.log for both preupgrade and upgrade? Or maybe just leapp-run.log?

fernflower commented 2 years ago

/rerun 850

github-actions[bot] commented 2 years ago

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/3656342

github-actions[bot] commented 2 years ago

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/3656353

github-actions[bot] commented 2 years ago

Testing Farm request for 7to8/3656353,3656342 regression testing has been created. Once finished, results should be available here. Full pipeline log.

github-actions[bot] commented 2 years ago

Testing Farm request for 8to9/3656353,3656342 regression testing has been created. Once finished, results should be available here. Full pipeline log.

fernflower commented 2 years ago

This one came in pair with https://github.com/oamg/leapp-repository/pull/850 which is now closed in favor of https://github.com/oamg/leapp/pull/764