oamg / leapp

Leapp - Application & OS Modernization Framework (For in-place upgrades, follow leapp-repository)
https://oamg.github.io/leapp/
Apache License 2.0
87 stars 70 forks source link

logging: Fix missing logging #764

Closed vinzenz closed 2 years ago

vinzenz commented 2 years ago

Previously we started using logging before it had been initialized. Which resulted in leapp stopping to log for some logger names the debug output. We did not know why this happened. It turns out that fileConfig from the logging library has a parameter disable_existing_loggers which is by default set to True and will set all loggers that have existed before the call to fileConfig to disabled. Which in turn will make them stop logging of course. This patch will change this behaviour and set disable_existing_loggers to False in order to have existing loggers be still enabled.

Signed-off-by: Vinzenz Feenstra vfeenstr@redhat.com

github-actions[bot] commented 2 years ago

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergable. If you want to re-run tests or request review, you can use following commands as a comment:

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

Rezney commented 2 years ago

/rerun

github-actions[bot] commented 2 years ago

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/3665300

github-actions[bot] commented 2 years ago

Testing Farm request for 7to8/3653299,3665300 regression testing has been created. Once finished, results should be available here. Full pipeline log.

github-actions[bot] commented 2 years ago

Testing Farm request for 8to9/3653299,3665300 regression testing has been created. Once finished, results should be available here. Full pipeline log.