Preserve the original inhibitor detection valid for now

[pirat89]

As we substituted Tags and Flags with Groups recently, it has impact on original detection of inhibitor inside leapp-repository which is not compatible with the new reporting implementation. As it could happen that new framework and old leapp-repository could be installed on the system, the consequence in such a case is that inhibitors will not be caught and user running:

  # leapp upgrade --reboot

could hit various serious issues. This change make sure we keep the original functionality working, until we drop flags & tags completely, providing enough time to everyone to adapt to new changes.

[github-actions[bot]]

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergable. If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

• review please to notify leapp developers of review request
• /packit copr-build to submit a public copr build using packit

To launch regression testing public members of oamg organization can leave the following comment:

• /rerun to schedule basic regression tests using this pr build and leapp-repository*master* as artifacts
• /rerun 42 to schedule basic regression tests using this pr build and leapp-repository*PR42* as artifacts
• /rerun-all to schedule all tests (including sst) using this pr build and leapp-repository*master* as artifacts
• /rerun-all 42 to schedule all tests (including sst) using this pr build and leapp-repository*PR42* as artifacts

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

[centos-ci]

Can one of the admins verify this patch?

[MichalHe]

Tested the patch, works as expected. Builds used during the testing:

• leapp - current master
• leapp-PR781 - this PR
• leapp-repository-old - leapp repository without modified inhibition detection
• leapp-repository-new - leapp repository with modified inhibition detection

Correctly inhibits?	leapp	leapp-PR781
leapp-repository-old	:red_circle:	:heavy_check_mark:
leapp-repository-new	:heavy_check_mark:	:heavy_check_mark:

[pirat89]

/packit build

[fernflower]

Please fix linter error.

************* Module leapp.reporting.__init__
leapp/reporting/__init__.py:330:0: C0301: Line too long (157/120) (line-too-long)

[pirat89]

@fernflower fixed & squashed

[fernflower]

/rerun

[github-actions[bot]]

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/4630650

[github-actions[bot]]

Testing Farm request for RHEL-8.6-rhui/4630618;4630650 regression testing has been created. Once finished, results should be available here. Full pipeline log.

[github-actions[bot]]

Testing Farm request for RHEL-7.9-rhui/4630618;4630650 regression testing has been created. Once finished, results should be available here. Full pipeline log.

[github-actions[bot]]

Testing Farm request for RHEL-8.6.0-Nightly/4630618;4630650 regression testing has been created. Once finished, results should be available here. Full pipeline log.

[github-actions[bot]]

Testing Farm request for RHEL-7.9-ZStream/4630618;4630650 regression testing has been created. Once finished, results should be available here. Full pipeline log.

[fernflower]

/rerun

[github-actions[bot]]

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/4684364

[github-actions[bot]]

Testing Farm request for RHEL-8.6-rhui/4656862;4684364 regression testing has been created. Once finished, results should be available here. Full pipeline log.

[github-actions[bot]]

Testing Farm request for RHEL-7.9-rhui/4656862;4684364 regression testing has been created. Once finished, results should be available here. Full pipeline log.

[github-actions[bot]]

Testing Farm request for RHEL-8.6.0-Nightly/4656862;4684364 regression testing has been created. Once finished, results should be available here. Full pipeline log.

[github-actions[bot]]

Testing Farm request for RHEL-7.9-ZStream/4656862;4684364 regression testing has been created. Once finished, results should be available here. Full pipeline log.

[fernflower]

@pirat89 Tried adding a commit into your branch and got permission denied. Could you please allow it? Or maybe just fix the issue I pointed out?

diff --git a/leapp/utils/report.py b/leapp/utils/report.py
index 6248101..71a2f29 100644
--- a/leapp/utils/report.py
+++ b/leapp/utils/report.py
@@ -147,5 +147,7 @@ def generate_report_file(messages_to_report, context, path, report_schema='1.1.0
                 # be negatively affected until we drop flags and tags completely.
                 messages_to_report = list(messages_to_report)
                 for msg in messages_to_report:
-                    msg.pop('flags')
+                    # NOTE(ivasilev) As flags field is created only if there is an inhibitor a default value to pop
+                    # has to be specified not to end up with a KeyError
+                    msg.pop('flags', None)
             json.dump({'entries': messages_to_report, 'leapp_run_id': context}, f, indent=2)

[pirat89]

@fernflower I cannot find out why you do not have the permission to commit into my fork, as regarding the github settings you should be able to do it. Let's experiment with that in future. I will just update the commit now to unblock it.

[fernflower]

/rerun

[github-actions[bot]]

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/4686481

[github-actions[bot]]

Testing Farm request for RHEL-8.6-rhui/4685924;4686481 regression testing has been created. Once finished, results should be available here. Full pipeline log.

[github-actions[bot]]

Testing Farm request for RHEL-7.9-rhui/4685924;4686481 regression testing has been created. Once finished, results should be available here. Full pipeline log.

[github-actions[bot]]

Testing Farm request for RHEL-8.6.0-Nightly/4685924;4686481 regression testing has been created. Once finished, results should be available here. Full pipeline log.

[github-actions[bot]]

Testing Farm request for RHEL-7.9-ZStream/4685924;4686481 regression testing has been created. Once finished, results should be available here. Full pipeline log.