oamg / leapp

Leapp - Application & OS Modernization Framework (For in-place upgrades, follow leapp-repository)
https://oamg.github.io/leapp/
Apache License 2.0
87 stars 70 forks source link

api: Preserve environment variables when calling a command #784

Closed matejmatuska closed 2 years ago

matejmatuska commented 2 years ago

When calling a command with _call and env parameter is not None, create and modify a copy of caller process environment variables and call the command with the copy in order to preserve them.

Jira ref: OAMG-7203

github-actions[bot] commented 2 years ago

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergable. If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

To launch regression testing public members of oamg organization can leave the following comment:

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

centos-ci commented 2 years ago

Can one of the admins verify this patch?

leapp-bot commented 2 years ago

This PR has been linked in issue tracker (#OAMG-7209).

vinzenz commented 2 years ago

Very nice, thanks a lot!