oamg / leapp

Leapp - Application & OS Modernization Framework (For in-place upgrades, follow leapp-repository)
https://oamg.github.io/leapp/
Apache License 2.0
87 stars 70 forks source link

Add reports summary to the output #818

Closed matejmatuska closed 1 year ago

matejmatuska commented 1 year ago

Previously only the paths to reports were printed and as a result the reports were easily missed.

Leapp now prints a list of HIGH and MEDIUM priority reports along with a summary of number of reports with individual severities to make reports more visible.

Example of the new output:

Screenshot from 2023-03-24 12-31-33

breaking changes

This change is incompatible with previous versions of leapp so the leapp-framework is going to be bumped to v 4.0. The leapp-repository needs to be updated also to be able to use the new leapp as it requires an update of CLI commands.

Jira ref.: OAMG-8586 Requires: https://github.com/oamg/leapp-repository/pull/1061

github-actions[bot] commented 1 year ago

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergable. If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

To launch regression testing public members of oamg organization can leave the following comment:

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

fernflower commented 1 year ago

/rerun

github-actions[bot] commented 1 year ago

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/5693905

github-actions[bot] commented 1 year ago

Testing Farm request for RHEL-7.9-rhui/5690410;5693905 regression testing has been created. Once finished, results should be available here. Full pipeline log.

github-actions[bot] commented 1 year ago

Testing Farm request for RHEL-7.9-ZStream/5690410;5693905 regression testing has been created. Once finished, results should be available here. Full pipeline log.

github-actions[bot] commented 1 year ago

Testing Farm request for RHEL-7.9-ZStream/5690410;5693905 regression testing has been created. Once finished, results should be available here. Full pipeline log.

fernflower commented 1 year ago

/rerun

github-actions[bot] commented 1 year ago

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/5732462

github-actions[bot] commented 1 year ago

Testing Farm request for RHEL-7.9-rhui/5715919;5732462 regression testing has been created. Once finished, results should be available here. Full pipeline log.

github-actions[bot] commented 1 year ago

Testing Farm request for RHEL-7.9-ZStream/5715919;5732462 regression testing has been created. Once finished, results should be available here. Full pipeline log.

github-actions[bot] commented 1 year ago

Testing Farm request for RHEL-7.9-ZStream/5715919;5732462 regression testing has been created. Once finished, results should be available here. Full pipeline log.

pirat89 commented 1 year ago

/packit build

pirat89 commented 1 year ago

Seeing also white text in case of errors or inhibitors:

screenshot_report_error

I am now thinking whether we want to stay with the white color in such case or whether we want to use the yellow/red in such cases. WDYT guys? @oamg/developers

pirat89 commented 1 year ago

@matejmatuska btw, regarding the API, I see it's needed here. So the leapp-framework capability should be bumped from 3.1 to 4.0 as it's incompatible with the previous one right now. requirements in leapp-repository needs to be updated then also.

matejmatuska commented 1 year ago

@pirat89 I squashed the commits and added information about the changes in API and also bumped the leapp-framework to 4.0. If we are going to keep the white color I believe this might be ready now.

fernflower commented 1 year ago

/rerun

github-actions[bot] commented 1 year ago

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/5922519

github-actions[bot] commented 1 year ago

Testing Farm request for RHEL-8.6-rhui/5911505;5922519 regression testing has been created. Once finished, results should be available here. Full pipeline log.

github-actions[bot] commented 1 year ago

Testing Farm request for RHEL-7.9-rhui/5911505;5922519 regression testing has been created. Once finished, results should be available here. Full pipeline log.

github-actions[bot] commented 1 year ago

Testing Farm request for RHEL-8.8.0-Nightly/5911505;5922519 regression testing has been created. Once finished, results should be available here. Full pipeline log.

github-actions[bot] commented 1 year ago

Testing Farm request for RHEL-8.6.0-Nightly/5911505;5922519 regression testing has been created. Once finished, results should be available here. Full pipeline log.

github-actions[bot] commented 1 year ago

Testing Farm request for RHEL-7.9-ZStream/5911505;5922519 regression testing has been created. Once finished, results should be available here. Full pipeline log.

github-actions[bot] commented 1 year ago

Testing Farm request for RHEL-7.9-ZStream/5911505;5922519 regression testing has been created. Once finished, results should be available here. Full pipeline log.

fernflower commented 1 year ago

Hmmm the tests are failing upon artifact installation,

Problem: package leapp-upgrade-el8toel9-0.18.0-100.20230511140705049292.master.24.g24bfccc.el8.noarch requires leapp-framework < 4, but none of the providers can be installed
  - cannot install both python3-leapp-0.15.1-0.202305160955Z.0d530a3.HEAD.PR818.el8.noarch and python3-leapp-0.15.1-0.20230504143926109663.pr826.8.gbce420b.el8.noarch
  - cannot install both python3-leapp-0.15.1-0.202305160955Z.0d530a3.HEAD.PR818.el8.noarch and python3-leapp-0.15.1-0.20230504181959398697.pr827.22.g7099099.el8.noarch
  - cannot install both python3-leapp-0.15.1-0.202305160955Z.0d530a3.HEAD.PR818.el8.noarch and python3-leapp-0.15.1-0.20230505103819842857.pr827.22.g05abcfe.el8.noarch
  - cannot install both python3-leapp-0.15.1-0.202305160955Z.0d530a3.HEAD.PR818.el8.noarch and python3-leapp-0.15.1-0.20230505120552826380.pr827.23.geeaa2c6.el8.noarch
  - cannot install both python3-leapp-0.15.1-0.202305160955Z.0d530a3.HEAD.PR818.el8.noarch and python3-leapp-0.15.1-0.20230505125657797257.pr828.7.g374584a.el8.noarch
  - cannot install both python3-leapp-0.15.1-0.202305160955Z.0d530a3.HEAD.PR818.el8.noarch and python3-leapp-0.15.1-0.202305051257Z.374584a.HEAD.PR828.el8.noarch
  - cannot install both python3-leapp-0.15.1-0.202305160955Z.0d530a3.HEAD.PR818.el8.noarch and python3-leapp-0.15.1-0.20230505130737588050.pr828.7.ga1b899e.el8.noarch
  - cannot install both python3-leapp-0.15.1-0.202305160955Z.0d530a3.HEAD.PR818.el8.noarch and python3-leapp-0.15.1-0.20230505133904547525.pr828.8.gf6c65eb.el8.noarch
  - cannot install both python3-leapp-0.15.1-0.202305160955Z.0d530a3.HEAD.PR818.el8.noarch and python3-leapp-0.15.1-0.202305051344Z.f6c65eb.HEAD.PR828.el8.noarch
  - cannot install both python3-leapp-0.15.1-0.202305160955Z.0d530a3.HEAD.PR818.el8.noarch and python3-leapp-0.15.1-0.20230507055151424808.pr826.8.gf5e9371.el8.noarch
  - cannot install both python3-leapp-0.15.1-0.202305160955Z.0d530a3.HEAD.PR818.el8.noarch and python3-leapp-0.15.1-0.202305090900Z.f6c65eb.HEAD.PR828.el8.noarch
  - cannot install both python3-leapp-0.15.1-0.202305160955Z.0d530a3.HEAD.PR818.el8.noarch and python3-leapp-0.15.1-0.202305090940Z.f5e9371.HEAD.PR826.el8.noarch
  - cannot install both python3-leapp-0.15.1-0.202305160955Z.0d530a3.HEAD.PR818.el8.noarch and python3-leapp-0.15.1-0.202305091329Z.07ff6eb.HEAD.el8.noarch
  - cannot install both python3-leapp-0.15.1-0.202305160955Z.0d530a3.HEAD.PR818.el8.noarch and python3-leapp-0.15.1-0.202305091517Z.032c009.HEAD.el8.noarch
  - cannot install both python3-leapp-0.15.1-0.202305160955Z.0d530a3.HEAD.PR818.el8.noarch and python3-leapp-0.15.1-0.20230515174545881278.pr829.11.g2cc4901.el8.noarch
  - cannot install both python3-leapp-0.15.1-0.202305160955Z.0d530a3.HEAD.PR818.el8.noarch and python3-leapp-0.15.1-100.20230509133631293244.master.8.g07ff6eb.el8.noarch
  - cannot install both python3-leapp-0.15.1-0.202305160955Z.0d530a3.HEAD.PR818.el8.noarch and python3-leapp-0.15.1-100.20230509151611316346.master.10.g032c009.el8.noarch
  - cannot install both python3-leapp-0.15.1-0.202305160955Z.0d530a3.HEAD.PR818.el8.noarch and python3-leapp-0.15.0-1.el8_6.1.noarch
  - cannot install both python3-leapp-0.15.1-0.202305160955Z.0d530a3.HEAD.PR818.el8.noarch and python3-leapp-0.15.1-1.el8_6.2.noarch
  - conflicting requests
fernflower commented 1 year ago

I will remove approval for now until it's clear to me what's causing it.

fernflower commented 1 year ago

/rerun

github-actions[bot] commented 1 year ago

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/5927337

github-actions[bot] commented 1 year ago

Testing Farm request for RHEL-8.6-rhui/5911505;5927337 regression testing has been created. Once finished, results should be available here. Full pipeline log.

github-actions[bot] commented 1 year ago

Testing Farm request for RHEL-7.9-rhui/5911505;5927337 regression testing has been created. Once finished, results should be available here. Full pipeline log.

github-actions[bot] commented 1 year ago

Testing Farm request for RHEL-8.6.0-Nightly/5911505;5927337 regression testing has been created. Once finished, results should be available here. Full pipeline log.

github-actions[bot] commented 1 year ago

Testing Farm request for RHEL-8.8.0-Nightly/5911505;5927337 regression testing has been created. Once finished, results should be available here. Full pipeline log.

github-actions[bot] commented 1 year ago

Testing Farm request for RHEL-7.9-ZStream/5911505;5927337 regression testing has been created. Once finished, results should be available here. Full pipeline log.

github-actions[bot] commented 1 year ago

Testing Farm request for RHEL-7.9-ZStream/5911505;5927337 regression testing has been created. Once finished, results should be available here. Full pipeline log.

fernflower commented 1 year ago

/rerun 1061

github-actions[bot] commented 1 year ago

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/5927439

fernflower commented 1 year ago

/rerun 1061

github-actions[bot] commented 1 year ago

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/5927772

github-actions[bot] commented 1 year ago

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/5927792

github-actions[bot] commented 1 year ago

Testing Farm request for RHEL-8.6-rhui/5927792;5927772 regression testing has been created. Once finished, results should be available here. Full pipeline log.

github-actions[bot] commented 1 year ago

Testing Farm request for RHEL-7.9-rhui/5927792;5927772 regression testing has been created. Once finished, results should be available here. Full pipeline log.

github-actions[bot] commented 1 year ago

Testing Farm request for RHEL-8.8.0-Nightly/5927792;5927772 regression testing has been created. Once finished, results should be available here. Full pipeline log.

github-actions[bot] commented 1 year ago

Testing Farm request for RHEL-8.6.0-Nightly/5927792;5927772 regression testing has been created. Once finished, results should be available here. Full pipeline log.

github-actions[bot] commented 1 year ago

Testing Farm request for RHEL-7.9-ZStream/5927792;5927772 regression testing has been created. Once finished, results should be available here. Full pipeline log.

github-actions[bot] commented 1 year ago

Testing Farm request for RHEL-7.9-ZStream/5927792;5927772 regression testing has been created. Once finished, results should be available here. Full pipeline log.

fernflower commented 1 year ago

Codewise lgtm, regression tests that rely on checking leapp report output require minor tuning due to obvious reasons (like 'Inhibitor: some message' being changed to 'some message' under inhibitors section) so I'd wait for QE's good to go. @mm0ran @mmacura311

fernflower commented 1 year ago

/rerun 1061

github-actions[bot] commented 1 year ago

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/5972604

github-actions[bot] commented 1 year ago

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/5972609

github-actions[bot] commented 1 year ago

Testing Farm request for RHEL-8.6-rhui/5972609;5972604 regression testing has been created. Once finished, results should be available here. Full pipeline log.

github-actions[bot] commented 1 year ago

Testing Farm request for RHEL-7.9-rhui/5972609;5972604 regression testing has been created. Once finished, results should be available here. Full pipeline log.