search

oantolin / embark

Emacs Mini-Buffer Actions Rooted in Keymaps
GNU General Public License v3.0
945 stars 56 forks source link

Create an embark-minimal-indicator #284

Closed minad closed 3 years ago

minad commented 3 years ago

...and remove support for strings in embark-action-indicator. Then we should really consider the snazzy verbose indicator as default ;)

And to not forget, add a few screenshots to the README, featuring the modus themes of course.

oantolin commented 3 years ago

I wrote the embark-minimal-indicator, and decided to unify the action and become indicators (which required a small update to the verbose indicator). 2b9053ffe26c4441cc12b28c865e66bf09382a9c

There are still several things to do:

oantolin commented 3 years ago

I didn't explicitly mention it in that last comment, but I did remove the string case of the indicator, they need to be functions now.

oantolin commented 3 years ago

Oh, and best of all: I made the verbose indicator the default! 🎉

minad commented 3 years ago

Great news! Thank you!

This may be controversial: I wonder do we still need embark become? I think I've not used it a single time. Or I've not understood where I would use it.

My main confusion with the command is that it has its own keymaps. Is embark-become not just the same as embark-act such that you always keep the input and such that you don't press RET? It would seem more embarkier to me if embark-become just offers the same keymap as the actions, meaning "become one of the actions".

The the verbose action indicator could be more helpful too. Press B x to become x.

Or is the idea that become is a coercion to another type? This would explain the separate keymaps.

EDIT: Okay, I've convinced myself of embark-become. It makes sense to have an ability to switch between related commands. It is conceptually sound, but I still think it is an edge case, which could probably be dropped without many users noticing ;)

minad commented 3 years ago

Oh and this issue can be closed! :tada:

oantolin commented 3 years ago

One item on the TODO list is done: I've rewritten the which-key indicator to conform to the new indicator protocol and thanks to @minad's tireless efforts it now updates for submenus!