search

oantolin / embark

Emacs Mini-Buffer Actions Rooted in Keymaps
GNU General Public License v3.0
882 stars 54 forks source link

Embark Act on pdf-tools active region text #718

Open idlip opened 2 months ago

idlip commented 2 months ago

Hi @oantolin !

I recently moved from docview to pdf-tools, and its seems good that there are some commits and activity over pdf-tools repo.

I just wondered since it allows to mark text region, it would be amazing to use embark act on it and tweak many actions.

(pdf-view-active-region-text) helps to get the text.

Since I did not see any issue or idea related to this, I thought to just ask and just open an issue to its visible to community.

If you dont want to include it in package itself, then I would like to kindly request you atleast to provide me with code that would help to use embark on pdf-tools.

Thank you for this package and the modern suite of packages, you and minad are empowering emacs! I really find all your comments on reddit, mastodon and few on matrix very helpful. Emacs & its community has been a great inspiration to me, minad and you are one of the best example for it.

Thank you!

oantolin commented 2 months ago

This is a good idea! I don't think pdf-tools belongs in embark proper, because Embark only supports only built-in Emacs packages (with the exception of completion frameworks: Vertico and Ivy, but completion is a very special case). But we can certainly put some pdf-tools support on the wiki. I'd probably even use it myself!

idlip commented 1 month ago

Hey, just a small reminder for this.