search

oap-project / gazelle_plugin

Native SQL Engine plugin for Spark SQL with vectorized SIMD optimizations.
Apache License 2.0
256 stars 77 forks source link

[NSE-1120] Support sum window function with order by statement #1122

Closed PHILO-HE closed 1 year ago

PHILO-HE commented 2 years ago

This patch is based on #1056. So we need rebase it after #1056 is merged.

github-actions[bot] commented 2 years ago

https://github.com/oap-project/native-sql-engine/issues/1120

PHILO-HE commented 1 year ago

Rebased the patch.

PHILO-HE commented 1 year ago

Refactored the code to put sort logic in a base abstract class for rank/row_number/lag/sort_sum. In the future, if we need to add more window function requiring sort, we just need to implement finish function to handle sorted partition for each group.

PHILO-HE commented 1 year ago

@jackylee-ch, please have a review and verification.