Remove project from wscg when it's the child of window

oap-project / gazelle_plugin

Native SQL Engine plugin for Spark SQL with vectorized SIMD optimizations.

Apache License 2.0

256 stars 77 forks source link

Remove project from wscg when it's the child of window #1136

Closed jackylee-ch closed 1 year ago

jackylee-ch commented 1 year ago

What changes were proposed in this pull request?

We meet the RecordBatch must be non-empty problem when there is a ColumnarWindowExec after WSCG and there is a ColumnarConditionProjectExec as a child of ColumnarWindowExec. It help use when we tried to remove the ColumnarConditionProjectExec from WSCG.

How was this patch tested?

unit tests and manual test.

github-actions[bot] commented 1 year ago

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/native-sql-engine/issues

Then could you also rename commit message and pull request title in the following format?

[NSE-${ISSUES_ID}] ${detailed message}