[NSE-1171] Throw RuntimeException when reading duplicate fields in case-insensitive mode

oap-project / gazelle_plugin

Native SQL Engine plugin for Spark SQL with vectorized SIMD optimizations.

Apache License 2.0

256 stars 76 forks source link

[NSE-1171] Throw RuntimeException when reading duplicate fields in case-insensitive mode #1173

Closed jackylee-ch closed 1 year ago

jackylee-ch commented 1 year ago

What changes were proposed in this pull request?

We didn't cover the corner case when reading duplicate fields in case-insensitive mode. If there is one more field matched, we just return the first field that matched. However in vanilla spark, it will throw RuntimeException in theses cases.

How was this patch tested?

unit tests

github-actions[bot] commented 1 year ago

https://github.com/oap-project/native-sql-engine/issues/1171

PHILO-HE commented 1 year ago

Thanks for your patch. All internal tests have passed. The patch looks good to me. @zhouyuan, please have a further check.