Pick up log4j config files from environment variable if not set in config override

oap-project / raydp

RayDP provides simple APIs for running Spark on Ray and integrating Spark with AI libraries.

Apache License 2.0

293 stars 66 forks source link

Pick up log4j config files from environment variable if not set in config override #326

Closed pang-wu closed 1 year ago

pang-wu commented 1 year ago

Enable system admin or infra team to set log4j config file from SPARK_LOG4J_CONFIG_FILE_NAME and RAY_LOG4J_CONFIG_FILE_NAME environment variable. So the user don't have to know these system details.

jiafuzha commented 1 year ago

@pang-wu Could you please also update the doc accordingly in doc/ray_on_spark.md? You can scroll down and update the last item. Or add a new item for logging. thanks

pang-wu commented 1 year ago

@pang-wu Could you please also update the doc accordingly in doc/ray_on_spark.md? You can scroll down and update the last item. Or add a new item for logging. thanks

done. I also updated raydp-submit

jiafuzha commented 1 year ago

LGTM

carsonwang commented 1 year ago

Merged. Thanks!