search

oap-project / sql-ds-cache

Spark* plug-in for accelerating Spark* SQL performance by using cache and index at SQL data source layer.
Apache License 2.0
37 stars 25 forks source link

Ape base #222

Open yspMing opened 2 years ago

yspMing commented 2 years ago

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

github-actions[bot] commented 2 years ago

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/sql-ds-cache/issues

Then could you also rename pull request title and commit log in the following format?

[SQL-DS-CACHE-${ISSUES_ID}] ${detailed message}

See also:

yspMing commented 2 years ago

Thanks a lot for Kunshang’s review.

I commit a new C++ file instead of adding function to the existing expression so that the basic version wouldn’t be polluted. Yes they can be merged and become more clear.

And I’ll look for and the other issues you mentioned and repair these.

jikunshang commented 2 years ago

CI failed at code style check stage. Please fix it.