Experiment tools: bad bash call

[mpoquet]

Description

The experiment tools generate different bash scripts then execute them.

Some of these bash scripts cannot be executed directly from the experiment tools. However, these bash scripts seems fine, as running them directly seems to work...

Steps to reproduce

• Use the data_storage branch, commit d437b38a64eee7a6fa8c9be for example
• In the batsim_command of file ./tools/experiments/instance_examples /pybatsim_filler_medium.yaml, execute batsim with valgrind: valgrind batsim ... instead of batsim ...
• Make sure a Redis server is running
• Run the example from batsim's root directory:

  ./tools/experiments/execute_one_instance.py \
    -od test/out/instance_examples/pfmedium \
    ./tools/experiments/instance_examples/pybatsim_filler_medium.yaml

Output

Execution script output

2016-09-09 17:32:31,663 INFO: Working directory: /home/carni/proj/batsim
2016-09-09 17:32:31,663 INFO: Output directory: test/out/instance_examples/pfmedium
2016-09-09 17:32:31,663 INFO: Batsim command: "valgrind batsim -p platforms/energy_platform_homogeneous_no_net_128.xml -w workload_profiles/batsim_paper_workload_example.json -e test/out/instance_examples/pfmedium/out"
2016-09-09 17:32:31,663 INFO: Sched command: "python2 schedulers/pybatsim/launcher.py ${pybatsim_algo}"
usage: valgrind [-p PLATFORM] [-w WORKLOAD] [-W WORKFLOW] [-e EXPORT] [-E]
                [-h] [-l LIMIT_MACHINE_COUNT] [-L] [-m MASTER_HOST] [-q]
                [-s SOCKET] [-t] [-T] [-v VERBOSITY]
valgrind: error: unrecognized arguments: batsim
[carni:~/proj/batsim] $ ./tools/experiments/execute_one_instance.py     -od test/out/instance_examples/pfmedium     ./tools/experiments/instance_examples/pybatsim_filler_medium.yaml
Variables = {'platform': 'platforms/energy_platform_homogeneous_no_net_128.xml', 'workload': 'workload_profiles/batsim_paper_workload_example.json', 'working_directory': '/home/carni/proj/batsim', 'pybatsim_algo': 'fillerSched', 'output_directory': 'test/out/instance_examples/pfmedium'}
2016-09-09 17:37:51,907 INFO: Working directory: /home/carni/proj/batsim
2016-09-09 17:37:51,907 INFO: Output directory: test/out/instance_examples/pfmedium
2016-09-09 17:37:51,907 INFO: Batsim command: "valgrind batsim -p platforms/energy_platform_homogeneous_no_net_128.xml -w workload_profiles/batsim_paper_workload_example.json -e test/out/instance_examples/pfmedium/out"
2016-09-09 17:37:51,907 INFO: Sched command: "python2 schedulers/pybatsim/launcher.py ${pybatsim_algo}"
usage: valgrind [-p PLATFORM] [-w WORKLOAD] [-W WORKFLOW] [-e EXPORT] [-E]
                [-h] [-l LIMIT_MACHINE_COUNT] [-L] [-m MASTER_HOST] [-q]
                [-s SOCKET] [-t] [-T] [-v VERBOSITY]
valgrind: error: unrecognized arguments: batsim

"Normal" output

This output is obtained by calling the bash scripts generated by the previous command. Run batsim: bash test/out/instance_examples/pfmedium/batsim_command.sh

==10523== Memcheck, a memory error detector
==10523== Copyright (C) 2002-2015, and GNU GPL'd, by Julian Seward et al.
==10523== Using Valgrind-3.11.0 and LibVEX; rerun with -h for copyright info
==10523== Command: batsim -p platforms/energy_platform_homogeneous_no_net_128.xml -w workload_profiles/batsim_paper_workload_example.json -e test/out/instance_examples/pfmedium/out
==10523== 
[0.000000] [workload/INFO] Loading JSON workload 'workload_profiles/batsim_paper_workload_example.json'...
[0.000000] [jobs/INFO] Loaded job 0 from workload workload_profiles/batsim_paper_workload_example.json
[0.000000] [jobs/INFO] Loaded job 1 from workload workload_profiles/batsim_paper_workload_example.json
...
[0.000000] [network/INFO] Creating UDS socket on '/tmp/bat_socket'
[0.000000] [network/INFO] Waiting for an incoming connection...

[mpoquet]

Fixed on commit 6696ee4a.