Closed RaMdsC closed 5 years ago
Thanks a lot for your contribution, I'm at SC18 right now but I will give you feedback next week.
Codacy suggests that you replace the xml library.
@mpoquet is it ok for you?
I think that's great :).
I would just add that it can be dangerous to model cores as hosts, as it removes the computations constraints usually present between cores. It can be perfectly fine if the scheduling is done at a finer grain in the decision process (e.g., to assign tasks to cores), but it can be misleading otherwise (with the traditional higher-level view of jobs in batsim workloads).
Merged in 08b1b07.
The merging process required some tricky rebases and editions, I hope I took all code related to this PR. Thanks again a lot @RaMdsC, please write your next pull request in a dedicated branch so merging is easier ;).
Cool, will do sorry for the inconvenience, definitely need to improve my Git skills! :)
Appreciate any kind of feedback :)