oar-team / batsim

Batsim: Infrastructure simulator for job and I/O scheduling
GNU Lesser General Public License v3.0
30 stars 15 forks source link

Heterogeneous platforms generation proposal #47

Closed RaMdsC closed 5 years ago

RaMdsC commented 5 years ago

Appreciate any kind of feedback :)

mickours commented 5 years ago

Thanks a lot for your contribution, I'm at SC18 right now but I will give you feedback next week.

mickours commented 5 years ago

Codacy suggests that you replace the xml library.

mickours commented 5 years ago

@mpoquet is it ok for you?

mpoquet commented 5 years ago

I think that's great :).

I would just add that it can be dangerous to model cores as hosts, as it removes the computations constraints usually present between cores. It can be perfectly fine if the scheduling is done at a finer grain in the decision process (e.g., to assign tasks to cores), but it can be misleading otherwise (with the traditional higher-level view of jobs in batsim workloads).

mpoquet commented 5 years ago

Merged in 08b1b07.

The merging process required some tricky rebases and editions, I hope I took all code related to this PR. Thanks again a lot @RaMdsC, please write your next pull request in a dedicated branch so merging is easier ;).

RaMdsC commented 5 years ago

Cool, will do sorry for the inconvenience, definitely need to improve my Git skills! :)