oar-team / batsim

Batsim: Infrastructure simulator for job and I/O scheduling
GNU Lesser General Public License v3.0
30 stars 15 forks source link

[bug] "speed" and "core" host attributes in Simgrid platform are not forwarded by Batsim #54

Open Thlr opened 4 years ago

Thlr commented 4 years ago

Description
On a Simgrid platform where attributes "speed" and "core" are defined, Batsim does not forward them in the SIMULATION_BEGINS message.

How to reproduce

Platform used

``` ```

Expected behavior I should see core and speed fields in the properties field of the nodes, in the SIMULATION_BEGINS message.

Current behavior I do not have them :

{"id":1,"name":"graphene-11.nancy.grid5000.fr","state":"idle","properties":{"role":"","memory":"4Gi"}}

Is this a bug or am I missing out on something?

Mommessc commented 4 years ago

Speed and core are actual attributes of a host and not additional properties. I think these should be added next to the id, name and state in the JSON dict of each machine in the SIMULATION_BEGINS event.

Mema5 commented 3 years ago

I agree. These two attributes are still not forwarded in the latest version of batsim

Is it something that is planned to be included in the next version of the Protocol @mpoquet ?

mpoquet commented 3 years ago

Yes, hosts in the future batprotocol will have these attributes :).

Mema5 commented 3 years ago

In the same vein, it would be good to have all the Batsim options forwarded to the scheduler in the SIMULATION_BEGIN, in order to test from the scheduler which options have been enabled and eventually send a warning to the user if one option is mandatory for this scheduler.

I'm thinking for example about the options --energy and --enable-compute-sharing which are not forwarded if I'm not mistaken.

mpoquet commented 3 years ago

I agree that it would be a good addition. Opened #126 to track it.