oaregithub / oare_sql

1 stars 0 forks source link

Line numbering with # of broken lines specified #11

Closed edstratford closed 1 year ago

edstratford commented 1 year ago

Geretrudius opened this issue in oare_mono:

There are a number of # undeterminedLines not displaying correctly due to a mismatch in the line number for the object. We either need to increment the following lines in a given text to match or maybe use the number of lines to display the following line numbers + that number.

The below query returns the undeterminedLines in text_epigraphy joined with text_markup. Unfortunately several of the ones I checked manually with reference to images or OCHRE etc. have specific complications that will need to be fixed manually, so I'm not sure this can be addressed programmatically.

SELECT * FROM text_epigraphy AS te INNER JOIN text_markup AS tm ON te.uuid = tm.reference_uuid WHERE te.type = "undeterminedLines"

edstratford commented 1 year ago

Stratford Aug 5, 2022:

Working through issues here: https://docs.google.com/spreadsheets/d/138oULIUcPxjWXErpCRDTPh6I2Suz5lfPYP7V87iqedY/edit#gid=0 This effort will ensure that none are erroneous, that the representation of lines missing is appropriate, and that they do not have line number or char_on_tablet, etc.

UndeterminedLines shouldn't have line numbers ... so we need to incorporate that into front-end display... should also determine whether these should be converted to 'region'.

Will check to see if there are regions that are determined by undeterminedLines in text_markup.

edstratford commented 1 year ago

Stratford, Aug 6, 2022: Having deleted the line numbers for undeterminedLines, the display now looks like this:

image

Will need to decide on whether to convert to region first, then update front end

edstratford commented 1 year ago

Issue already resolved