search

oarepo / oarepo-ui

MIT License
0 stars 2 forks source link

Makisheva/header frontpage #185

Closed AlbinaMakisheva closed 2 months ago

mirekys commented 4 months ago

I'm not sure if I'm doing something wrong while reviewing, but navbar on nr-docs#main gets quite messed up using this PR:

Screenshot 2024-06-19 at 17 14 49
mirekys commented 4 months ago

Even more so with any other pages (search, dashboards, forms...)

Screenshot 2024-06-19 at 17 22 21
mirekys commented 3 months ago

Weird account button, text truncated way before dropdown arrow

Screenshot 2024-06-28 at 12 08 00
mirekys commented 3 months ago

Removed/incorrect whitespace around navbar & footer - breaks vertical alignment on left & right for e.g. nr-docs & NMA sites:

before:

Screenshot 2024-06-28 at 12 22 55

after:

Screenshot 2024-06-28 at 12 24 03
mirekys commented 3 months ago

still no alignment to rest of page content width, on larger screens looks like: Screenshot 2024-07-09 at 13 12 47

on mobile: Screenshot 2024-07-09 at 13 16 03

footer has the same problem

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
2 New issues
12 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud