oarevalo / BugLogHQ

BugLogHQ is a tool to centralize the handling of automated bug reports from multiple applications. BugLogHQ provides a unified view of error messages sent from any number of applications, allowing the developer to search, graph, forward, and explore the bug reports submitted by the applications.
http://www.bugloghq.com
155 stars 67 forks source link

Slack alert, no data sometimes? #134

Closed KrunchMuffin closed 8 years ago

KrunchMuffin commented 8 years ago

Any idea why this would happen? It's only sometimes and I can't figure out why.

image

slackAlert.cfc.txt

oarevalo commented 8 years ago

I think the reason may be that you have a line:

 qry = oEntryFinder.search(argumentCollection = args)

But then it calls sendEmail(qry, rawEntry); without checking for the results of the search. So I guess even if the search does not find anything it will cause a notification to be sent.

In other words, if it doesn't exit on the "fail fast" conditions at the beginning of processRule, then it will send a notification for any other message; but the contents of the notification may be an empty recordset.

KrunchMuffin commented 8 years ago

thing is, I get an email as well with data and there is a bug logged.

KrunchMuffin commented 8 years ago

i switched it around to what the pushbullet one is using and seems better now.

oarevalo commented 8 years ago

Closing this ticket since it looks like the last suggestion worked. Feel free to open a new ticket if you have any issues