search

oarevalo / BugLogHQ

BugLogHQ is a tool to centralize the handling of automated bug reports from multiple applications. BugLogHQ provides a unified view of error messages sent from any number of applications, allowing the developer to search, graph, forward, and explore the bug reports submitted by the applications.
http://www.bugloghq.com
154 stars 67 forks source link

Use of cgi.http_method in BugLogListenerREST #19

Closed bcswartz closed 11 years ago

bcswartz commented 11 years ago

While working on making BugLogHQ compatible with Oracle (looking good so far, should have code to contribute back soon), I got an error while running the test of the REST listener on my local machine (Mac OS, Apache, CF 9.0.1). Tracked the error back to line 21 of BugLogListenerREST.cfm, where the source value for the bug log entry is pulled from "cgi.http_method".

Unless I'm missing something, there is no "http_method" key in the CGI scope. This line should be using cgi.request_method. Once I fixed that line on my machine, it worked fine.

oarevalo commented 11 years ago

Hi Brian, You are completely right! Funny thing is that on my dev environment (Railo 3.3 + Tomcat 7) the use of cgi.http_method didn't raise any error, and actually just returns an empty string. Moreover, the autocomplete of cfeclipse showed it as a member of the cgi scope (that's why I used it on the first place). And since the "source" attribute of the entry is no longer displayed on the UI I never thought much of it.

Anyway, I just replaced with the correct cgi variable (request_method) and pushed it to the master.

Thanks again for letting me know and I can't wait to see what you did for the Oracle compatibility, I'm sure there will be lots of folks who will welcome it.

Oscar