search

oarevalo / BugLogHQ

BugLogHQ is a tool to centralize the handling of automated bug reports from multiple applications. BugLogHQ provides a unified view of error messages sent from any number of applications, allowing the developer to search, graph, forward, and explore the bug reports submitted by the applications.
http://www.bugloghq.com
154 stars 67 forks source link

Official constant for CFDump's "top" parameter in CF client service #33

Closed michael-zock closed 11 years ago

michael-zock commented 11 years ago

This is somewhat related to the sanitizeDump() introduced in issue #30.

When dumping out extra data, related ORM entities can quickly blow up into a ton of used memory, because by the default the "top" parameter of the tag is set to 9999, meaning the tag will cascade down the next 9998 encapsulation instances as well Resulting heap memory errors due to this are not that uncommon in some more complex applications.

Adding something like "variables.max_dump_depth" would make it the user's responsibility to specify that.

Making it an optional argument for the notifyService() would allow even for more flexibility, but probably cause more work as well, since it changes the facade of the interface (might have top be reflected in other client services).

oarevalo commented 11 years ago

I changed the default value to 15. The whole point of buglog is sending data through the wire, so 9999 nested structs would not be practical (assuming that your server doesn't crash processing a cfdump like that).