search

oarevalo / BugLogHQ

BugLogHQ is a tool to centralize the handling of automated bug reports from multiple applications. BugLogHQ provides a unified view of error messages sent from any number of applications, allowing the developer to search, graph, forward, and explore the bug reports submitted by the applications.
http://www.bugloghq.com
154 stars 67 forks source link

notifyService() needs some minor null handling when REST is used. #69

Closed michael-zock closed 10 years ago

michael-zock commented 10 years ago

This concerns something a colleague of mine ran into earlier. Without a precaution in this spot the service could run into a NullPointerException if a variable contains a null.

oarevalo commented 10 years ago

good catch!, however I'm thinking that sending the "null" string could be confusing. Since all parameters are optional on the REST listener, It will be better if the client just omit the null value completely.

michael-zock commented 10 years ago

Omitting the null values could lead to problems as well, but if you want I'll remove the else block.