Breaking change detected but action does not fail

oasdiff / oasdiff-action

GitHub action for comparing and detect breaking changes in OpenAPI specs

Apache License 2.0

38 stars 24 forks source link

Breaking change detected but action does not fail #5

Closed nicolassanmar closed 1 year ago

nicolassanmar commented 1 year ago

I'm using the action oasdiff/oasdiff-action/check-breaking@main to check for breaking changes between two specs. The action reports a breaking change, but it does not fail. I suspect it is because it is just a "warning" but it actually is a breaking change between the specs, and the action prints a log that says there is 1 breaking change

I also have fail-on-diff: true but it does not fail either.

Screenshot of issue

effoeffi commented 1 year ago

Thanks @nicolassanmar, fixed, see PR