oasis-art-project / oasis-server

Platform for the local arts
Other
2 stars 0 forks source link

New Signups page doesn't show up when clicking the signup button #28

Closed cwille97 closed 5 years ago

cwille97 commented 5 years ago

I wrote some code for the signups page and added it to the routes.js file. When I click the button it goes to the correct href but gives a 404 error. I have tried rebuilding project files and a hard refresh in the browser.

tsybanov commented 5 years ago

The next time, please, put some references or links to the commits which were affected in a described problem

tsybanov commented 5 years ago

@cwille97 If we are talking about this commit: https://github.com/codeanticode/OASIS/commit/28d74f86c77c020b1d232fec1ec570df07e37188 I see the new path in the router, but I don't see any containers with a Signup name. There is no such container in the container folder. Therefore, React can't call it. Try to create a container and test it.

cwille97 commented 5 years ago

@Tsybanov There was an issue with the commit. I have a container named "Signup.js" with a corresponding "Signup.css" both in my local containers folder. For some reason it didn't get pushed to the repository although I could've sworn I did git commit -a -m. I will push them now.

cwille97 commented 5 years ago

It is now working on my end. I don't know what happened because this morning the only thing I changed was double checking that the commits were properly pushed to the repository and then I tried running the server again and it worked.