search

oasis-art-project / oasis-server

Platform for the local arts
Other
2 stars 0 forks source link

Return list of images in get endpoints #75

Closed codeanticode closed 4 years ago

codeanticode commented 4 years ago

Right now, there is a separate endpoint to list the images associated to a given element (event, artist, etc), which has the following format:

$SERVER_URL/api/media/$RESOURCE_ID?resource-kind=event

This makes it harder to implement the server. It would be much more easier if the list of images are added to the get request.

codeanticode commented 4 years ago

Implemented in https://github.com/codeanticode/oasis-server/commit/300976a90052aec31af5145909060f0fe8dd3927

codeanticode commented 4 years ago

The current implementation is too slow, as it lists the local or S3 folder every time get is called:

image

codeanticode commented 4 years ago

Should be solved with this: https://github.com/codeanticode/oasis-server/commit/6177050a87873ec415ae8c153b7fc82303130b18