Closed berezovskyi closed 3 years ago
Acknowledged. We'll watch for the results of the PGB vote on Sept. 10.
@OASIS-OP-Admin is it possible to do pre-publication review for the package in parallel, please? We have not received any critical feedback so far.
@OASIS-OP-Admin we just held a PGB meeting. 3/4 members were in attendance. 3/3 attending members voted to promote AM PSD: https://lists.oasis-open-projects.org/g/oslc-op-pgb/topic/pgb_minutes/76756760?p=,,,50,0,0,0::recentpostdate%2Fsticky,,,50,2,0,76756760
Please proceed with the package review and publication.
@paul-knight did you have a chance to check the package? Thank you in advance!
It would be very helpful to provide a link for the ZIP file in this ticket:
Hmmm. seeing some problems:
Part 1 - spec:
Part 2 - Constraints (This should be "Part 3", I think) (also change in the Citation format)
Real Part 2 - Vocabulary
Part 1 - spec:
[x] "Additional components" only shows two of the five parts (all five are listed in Part 2) (but be aware of change needed - see Part 2/3 - Constraints)
[x] Under "Latest stage", the hyperlink under "https://docs.oasis-open-projects.org/oslc-op/am/v3.0/architecture-management-spec.pdf" points to the HTML instead of the PDF (This is broken in all three parts!) - see ReSpec issue: https://github.com/oasis-tcs/tab-respec/issues/42
[x] Under Normative references, the URL for [OSLCCore3] should be the OASIS link, since it is published: Latest stage: https://docs.oasis-open-projects.org/oslc-op/core/v3.0/oslc-core.html (similar to treatment of [OSLCPreview] ) (this is used in all three main parts - would be good to change all)
[x] In Appendix A, the link appears to be broken.
Part 3 - Constraints
[x] This should be "Part 3", I think (also change in the Citation format)
[x] All of the URIs use "shape", but the file is named "shapes", and is listed in "Additional components" as "shapes" - Yes, to indicated the file is a collection of individual shapes.
[x] Also in "Additional components", this is listed as Part 3, but the title says Part 2. I think "3" is correct.
Real Part 2 - Vocabulary
I'm assuming that there will be a note placed here when the updated files are ready. If the only remaining issue is the "Latest stage" hyperlink, I will be happy to fix that manually...
I plan on giving you a new zip file soon.
The updated Zip file is here: https://github.com/oslc-op/oslc-specs/releases/download/untagged-ed7751fd51dac5e2a28d/am-v3.0-psd01.zip
Thanks, Jim! I'm pretty sure I can get this out next week. Should be by 22 October.
Reviewed files briefly - no issues noted. Prepared PDF files by temporarily loading the HTML files into the OASIS OP Library and using them as the sources for WKHTMLTOPDF. Set up installation scripts and support files. Should be ready for staging operations.
Installed files in staging directory:
Please review the staging server installation of the files for OSLC AM-v3.0-psd01.
This has three main parts, with two Turtle files. The files are:
OSLC Architecture Management Version 3.0 Project Specification Draft 01 17 September 2020
OSLC Architecture Management Version 3.0. Part 1: Specification https://docs-staging.oasis-open-projects.org/ztest/oslc-op/am/v3.0/psd01/architecture-management-spec.html https://docs-staging.oasis-open-projects.org/ztest/oslc-op/am/v3.0/psd01/architecture-management-spec.pdf OSLC Architecture Management Version 3.0. Part 2: Vocabulary https://docs-staging.oasis-open-projects.org/ztest/oslc-op/am/v3.0/psd01/architecture-management-vocab.html https://docs-staging.oasis-open-projects.org/ztest/oslc-op/am/v3.0/psd01/architecture-management-vocab.pdf OSLC Architecture Management Version 3.0. Part 3: Constraints https://docs-staging.oasis-open-projects.org/ztest/oslc-op/am/v3.0/psd01/architecture-management-shapes.html https://docs-staging.oasis-open-projects.org/ztest/oslc-op/am/v3.0/psd01/architecture-management-shapes.pdf Machine Readable Vocabulary Terms: https://docs-staging.oasis-open-projects.org/ztest/oslc-op/am/v3.0/psd01/architecture-management-vocab.ttl Machine Readable Constraints: https://docs-staging.oasis-open-projects.org/ztest/oslc-op/am/v3.0/psd01/architecture-management-shapes.ttl
Please add comments to https://github.com/oasis-open-projects/administration/issues/15. Also tracked in https://issues.oasis-open.org/browse/TCADMIN-3799.
Attaching ZIP file for review by OP members, if desired: am-v3.0-psd01.zip
All looks good to me. I approve to promote to docs.oasis-open-projects.org
Synced files from /ztest to canonical directory (/htdocs)
Synced to OP Library (docs.oasis-open-projects.org)
checked links, etc. -- Part 1 - Three links to open-services.net are currently "404" - broken. Presumably the OSLC team which controls that domain will install the targets. -- Same for Part 2 (vocab) -- Part 3 failed - needs to be rebuilt - used wrong self-referential URIs on its front page (This stage and Latest stage at top, plus both URIs in the "Citation format" block). Part 3 uses "shape" instead of "shapes" in its URIs. - But its own file name and every cross-reference to it uses "shapes". I also listed this error as part of my comments on Sept. 17 above. -- To be clear, the six self-referential URIs listed on the front page MUST point to the file itself. The file is named "architecture-management-SHAPES.html", but the URIs listed on the front page all use "architecture-management-SHAPE.html", without the "S". I will go ahead and fix this, but the OSLC OP Editor needs to make this change in their source as well.
Cannot release yet. Should be ready Monday (10/26)
I'll leave the files in place over the weekend for internal review if desired, with the "AA-README-Warning-Do-Not-Download.txt" file in place.
Patched up the HTML file for Part 3 (replaced all "shape" with "shapes" in all URIs). Installed it temporarily into OASIS OP Library and generated PDF for Part 3. Updated the base-tagged HTML file for Part 3. Removed all the files in https://docs.oasis-open-projects.org/oslc-op/am/v3.0/psd01/. Should be ready for rebuilding the installation package and re-installing.
NOTE ON PDF GENERATION:
We generate the PDF from the HTML source using WKHTMLTOPDF. WKHTMLTOPDF does not preserve "relative links" - they are all transformed into fully-qualified domain name (FQDN) links. This means that the HTML file must be located in its intended location (in the OASIS OP Library - https://docs.oasis-open-projects.org/) before the PDF can be generated. We temporarily install the HTML file, then generate the PDF, then remove the HTML. Then we can construct the installation package (which contains a ZIP file with all components, and a manifest file with cryptographic hashes of each file).
There is another way to generate the PDF, by replacing every relative link in a temporary copy of the HTML file with a FQDN link, but it is more error-prone.
Files reinstalled. The only items I noted are the broken links for the open-services.net controlled URIs used for "Latest version" and "Latest editor's draft", plus the namespace links in "RDF Namespaces". Parts 1 and 2 have one namespace, while Part 3 has two. Requested sanity check before release:
Please review the OASIS OP Library installation of the files for OSLC AM-v3.0-psd01.
I did not note any issues other than the broken links for the open-services.net controlled URIs used for "Latest version" and "Latest editor's draft", plus the namespace links in "RDF Namespaces". I'll let the OP know about those, as well as the need to correct their copy of Part 3 (with its bad self-referential URIs which I corrected here).
The files are:
OSLC Architecture Management Version 3.0 Project Specification Draft 01 17 September 2020
OSLC Architecture Management Version 3.0. Part 1: Specification https://docs.oasis-open-projects.org/oslc-op/am/v3.0/psd01/architecture-management-spec.html https://docs.oasis-open-projects.org/oslc-op/am/v3.0/psd01/architecture-management-spec.pdf OSLC Architecture Management Version 3.0. Part 2: Vocabulary https://docs.oasis-open-projects.org/oslc-op/am/v3.0/psd01/architecture-management-vocab.html https://docs.oasis-open-projects.org/oslc-op/am/v3.0/psd01/architecture-management-vocab.pdf OSLC Architecture Management Version 3.0. Part 3: Constraints https://docs.oasis-open-projects.org/oslc-op/am/v3.0/psd01/architecture-management-shapes.html https://docs.oasis-open-projects.org/oslc-op/am/v3.0/psd01/architecture-management-shapes.pdf Machine Readable Vocabulary Terms: https://docs.oasis-open-projects.org/oslc-op/am/v3.0/psd01/architecture-management-vocab.ttl Machine Readable Constraints: https://docs.oasis-open-projects.org/oslc-op/am/v3.0/psd01/architecture-management-shapes.ttl
Please add comments to https://github.com/oasis-open-projects/administration/issues/15. Also tracked in https://issues.oasis-open.org/browse/TCADMIN-3799.
I checked over the files. They look ready to go. I approve to release.
Removed README warning file and reset directory timestamp in canonical directory on staging server.
synced to OP Library (docs.oasis-open-projects.org)
Ready for announcements.
Sent email announcement to OSLC email list:
I also sent a note to the Editors to make sure they know about the remaining issues:
Should be all done here - ready to close issue.
Thank you, I added your issues to the AM PS01 backlog.
I have fixed the -shape.html" to -shapes.html" (5).
Requester name: Andrew Berezovskyi
OP name: OSLC OP
OP email address: oslc-op@lists.oasis-open-projects.org
Title: OSLC Architecture Management v3.0 PSD 01
Request link: https://lists.oasis-open-projects.org/g/oslc-op/topic/intent_to_publish_oslc_am_psd/76437041?p=,,,50,0,0,0::recentpostdate%2Fsticky,,,50,2,0,76437041
Notes: @berezovskyi will initiate a PGB vote on September 10. Please check the package for OASIS rule conformance in parallel to enable publication with minimal delays.