search

oasis-open / cti-python-stix2

OASIS TC Open Repository: Python APIs for STIX 2
https://stix2.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
372 stars 120 forks source link

TAXIICollectionSource.get()/all_versions() - check id of returned objects #66

Closed elegantmoose closed 7 years ago

elegantmoose commented 7 years ago

Add simple sanity check for the TAXIICollectionSource.get()/all_versions() calls, where the id of the STIX objects returned from the TAXII endpoint are checked to match

elegantmoose commented 7 years ago

Have this implemented locally. Was going to wait(?) for Brets external server to work.; or can just push.

gtback commented 7 years ago

Go ahead and push/make a PR now. I'm not sure the best way to test (and if there's a good way without an external server), but we should at least start thinking about it.

rpiazza commented 7 years ago

Ignoring Travis, are you using the cti_taxii_server to test in your own environment?

elegantmoose commented 7 years ago

I was not but I can.

gtback commented 7 years ago

Thanks, @rpiazza . Using medallion for local testing is 100% the way to go; testing via Travis will be a bit harder. We may need to set up some mock responses.