search

oasis-open / cti-stix-common-objects

OASIS Cyber Threat Intelligence (CTI) TC: A repository for commonly used STIX objects in order to avoid needless duplication. https://github.com/oasis-open/cti-stix-common-objects
BSD 3-Clause "New" or "Revised" License
84 stars 37 forks source link

Re-add timestamp definition #17

Closed allink28 closed 1 year ago

allink28 commented 2 years ago

A few months ago the timestamp definition was moved to a separate file. Here I've added it back in because our system is not able to reach out to the web to use the schema. I'm not sure if the validation library I'm using is able to load and validate against multiple schema files at once, but thought I'd propose this as this is what we're currently going forward with.

CLAassistant commented 2 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

allink28 commented 2 years ago

Sorry, I'm not sure how the indentation changed.

rpiazza commented 2 years ago

Hi @allink28,

I did this because the timestamp property should only be defined once throughout the schemas. I'm not sure what the issue is with you reaching out to the web for it, but maybe it is something you should do locally?

ejratl commented 1 year ago

Closing this because significant time has passed without signing the CLA nor responding to Rich's comments.