oasis-open / cti-stix-common-objects

OASIS Cyber Threat Intelligence (CTI) TC: A repository for commonly used STIX objects in order to avoid needless duplication. https://github.com/oasis-open/cti-stix-common-objects
BSD 3-Clause "New" or "Revised" License
79 stars 36 forks source link

Comments on Incident Core Extension document (rev 10/10/23) #43

Open rpiazza opened 9 months ago

rpiazza commented 9 months ago

Not recommended

dc3-tsd commented 8 months ago

Thank you for catching these. We believe most of these are errors, but a few of these were intended:

  1. incident_types does come from event-type-ov to allow for consistency with other systems and avoiding creating duplicate open vocabularies. If another term can be created for this which is neutral it can certainly be renamed.
  2. It may be useful for there to be a link between an Event and a Threat Actor, but this could also cause confusion since performing attribution would imply work was done which would be tracked as a Task within the Incident. So we avoided making this relationship for the time being. If future use cases require it then it could certainly be added as a recommended relationship.
  3. Thank you for catching the lack of -ext within the impact extensions. These should be added and the documents should be revised as appropriate. Our only concern with implementing this now is it may break existing code as it is backwards breaking. That said since this is an extension proposal it would be better to fix this now, but we might need to officially flag a new version such as 2.0.1 or 2.1 for the incident extension.
  4. We have to keep the impact_category open in order to allow for the expansion of impact in the future. We also cannot forbid additional extensions within it since the STIX specification does not permit this in general. We may be able to state that it MUST only have one category style extension however while still allowing additional extensions in case implementers require additional internal data to be passed along with existing impacts.
  5. The use of "variety" from monetary impact was pulled from VERIS and kept for consistency.
  6. Agreed on conditions / sequences. While this was based off of CACAO several implementers have complained about this structure. One has begun to put forward a proposal for separate SDOs for capturing sequence information. That is outside the scope of this issue, but it may be worth considering for an additional revision as there isn't much code that requires the current sequence structure and STIX would benefit from a more generic way to pass sequence data outside of just the components of the Incident, Task, and Event objects.
rpiazza commented 8 months ago

We also cannot forbid additional extensions within it since the STIX specification does not permit this in general.

Not sure what you are trying to say here. Multiple extensions are allowed by the spec (or should be). File is an example where you might want to use more than one extension (that comes directly from Ivan who worked on SCOs with Trey).

I think we want to restrict mutliple Impact extensions - I don't see why that can't be normative language.

BTW - i defined the term "subtype extensions" in the extension policy document to describe the "predefined extensions" we have in the spec and that would be a good term to use for the Impact ones.

rpiazza commented 5 months ago

Some changes still pending

dzbeck commented 5 months ago

////////- [ ] Update Draft date from 10 October 2023

Vocabs/enums

Section 1

This reads fine for me.

We have to assume that anyone looking at extension specification has some familiarity with the STIX spec.

//// just the NEW objects, not the existing STIX objects (Event, Task, Impact). The third paragraph of the abstract is helpful, but I think three bullets in Section 1 would help make it clear how the three new SDOs relate to an incident and to each other. ////

Section 2.1

I hope this will be re-worked when Jeff discusses the other Incident proposal - https://github.com/os-threat/cti-stix-common-objects

Changed "outcome" to "status"

I think this is ok

The "style" is to only include new suggested relationships.

Section 2.2

Waiting on other Incident proposal - https://github.com/os-threat/cti-stix-common-objects

Section 2.4

NEW COMMENTS BELOW 2/8/24

Section 2.3

This has been changed to "An Event is an activity that has a harmful effect on the defender/victim."

Changed to "The category of impact this object applies to."

Changed to: Because these extensions are used to specify very different types of impacts, producers SHOULD use one and only one of these extensions. However, additional extensions might be proposed in the future and might be used in conjunction with one of these. Producers and consumers are terms from the spec's Conformance section

Changed to "decimal digits". I think fidelity is a slightly different concept than precision.

Section 2.4

Changed to: A Task is an activity that is performed by or for the victim/defender to respond to the attack.

dzbeck commented 5 months ago

/Comments 2/12/24

Section 2.1 Incident Core

Section 2.1.1 Relationships

Section 2.2

Section 2.2.1 Relationships

Section 2.3 Impact

Section 2.3.1

Section 2.3.2

Section 2.3.2.1

dzbeck commented 5 months ago

comments 2/13/24

Section 2.3.2.2

Section 2.3.2.3

Section 2.3.2.4

Section 2.3.2.5

Section 2.3.2.6

Section 2.3.2.7

dzbeck commented 5 months ago

comments 2/14/24

Section 2.4

Section 2.4.1

Section 3

(J) Section 3.2

(J) Section 3.3

Section 3.4

(J) Section 3.5

(J) Section 3.6

dzbeck commented 5 months ago

comments 2/15/24

Section 3.6

(J) Section 3.7

Section 4.4

Probably :-)