search

oasis-open / cti-stix-elevator

OASIS Cyber Threat Intelligence (CTI) TC Open Repository: Convert STIX 1.2 XML to STIX 2.x JSON
https://stix2-elevator.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
49 stars 23 forks source link

Improve incident #260

Closed rpiazza closed 3 years ago

rpiazza commented 3 years ago

improve incident and handling of stix1 statement type

codecov-commenter commented 3 years ago

Codecov Report

Merging #260 (08c5c43) into master (388b439) will decrease coverage by 0.00%. The diff coverage is 54.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
- Coverage   71.13%   71.13%   -0.01%     
==========================================
  Files          19       19              
  Lines        6295     6315      +20     
==========================================
+ Hits         4478     4492      +14     
- Misses       1817     1823       +6
Impacted Files Coverage Δ
stix2elevator/stix_stepper.py 0.00% <0.00%> (ø)
stix2elevator/missing_policy.py 53.95% <47.36%> (-0.55%) :arrow_down:
stix2elevator/convert_stix.py 82.52% <88.88%> (+0.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 388b439...08c5c43. Read the comment docs.

emmanvg commented 3 years ago

Not clear what areas of code need to be changed, but findings are mainly on content.