Add additional data validation logic

oasis-open / cti-stix-elevator

OASIS Cyber Threat Intelligence (CTI) TC Open Repository: Convert STIX 1.2 XML to STIX 2.x JSON

https://stix2-elevator.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

49 stars 23 forks source link

Add additional data validation logic #287

Closed cipherlock closed 2 years ago

cipherlock commented 2 years ago

Added additional data validation by checking for the existence of the authority_reference dictionary key
Ensuring that the prop.layer4_protocol.value has data and not just that the object exists

CLAassistant commented 2 years ago

All committers have signed the CLA.

cipherlock commented 2 years ago

@rpiazza As requested modified the output to be a list :-)

rpiazza commented 2 years ago

@ejratl - I approve these changes, but can no longer approve anything in Github on this repository.

cipherlock commented 2 years ago

Screen Shot 2022-08-18 at 10 16 45 AM

ejratl commented 2 years ago

@cipherlock hahahahaha too funny @rpiazza I don't have maintainership rights on this repo @JasonKeirstead Will you be able to handle this pull request, please?

JasonKeirstead commented 2 years ago

@rpiazza If you can't approve PRs here, should you be removed from https://github.com/oasis-open/cti-stix-elevator/README.md? Can Chris Lenk still approve?

ejratl commented 2 years ago

@JasonKeirstead There is a pending PR to do so #284 (from Jul. 13).