oasis-open / cti-stix-slider

OASIS TC Open Repository: The repository cti-stix-slider supports development of a Python application to convert STIX 2.0 content to STIX 1.x content
https://cti-stix-slider.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
21 stars 15 forks source link

Add ability to override default 'example' namespace. #33

Closed emmanvg closed 6 years ago

emmanvg commented 6 years ago

Related to #32

Added --use-namespace option.

codecov-io commented 6 years ago

Codecov Report

Merging #33 into master will increase coverage by 0.15%. The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   64.63%   64.78%   +0.15%     
==========================================
  Files          16       17       +1     
  Lines        5033     5055      +22     
==========================================
+ Hits         3253     3275      +22     
  Misses       1780     1780
Impacted Files Coverage Δ
stix2slider/cli.py 32.43% <0%> (-0.91%) :arrow_down:
stix2slider/convert_stix.py 66% <100%> (+0.24%) :arrow_up:
stix2slider/utils.py 89.47% <100%> (+2.8%) :arrow_up:
stix2slider/test/test_namespace.py 100% <100%> (ø)
stix2slider/test/test_idioms.py 77.67% <100%> (-0.59%) :arrow_down:
stix2slider/options.py 69.93% <50%> (+1.06%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 95a2d56...f8057d2. Read the comment docs.

rpiazza commented 6 years ago

@emmanvg @gtback: Hold off on merging this - I made some changes too that haven't been pushed, which I think conflict with what was done here.

rpiazza commented 6 years ago

@emmanvg: your changes subsume mine, so we should just merge this in and I will delete my branch. One thing - can you add --use-namespace to command-line.rst, then it will be ready for merging.

emmanvg commented 6 years ago

@rpiazza @gtback, it should be good to go now. I have added a test as well.