oasis-open / cti-stix-slider

OASIS TC Open Repository: The repository cti-stix-slider supports development of a Python application to convert STIX 2.0 content to STIX 1.x content
https://cti-stix-slider.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
21 stars 15 forks source link

Slider uses visitor from pattern-validator #38

Closed rpiazza closed 5 years ago

rpiazza commented 5 years ago

make slider work with base visitor from pattern-validator

codecov-io commented 5 years ago

Codecov Report

Merging #38 into master will increase coverage by 1.25%. The diff coverage is 65.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   64.93%   66.19%   +1.25%     
==========================================
  Files          17       12       -5     
  Lines        5062     2896    -2166     
==========================================
- Hits         3287     1917    -1370     
+ Misses       1775      979     -796
Impacted Files Coverage Δ
stix2slider/options.py 70.12% <100%> (+0.19%) :arrow_up:
stix2slider/__init__.py 40.84% <100%> (-0.83%) :arrow_down:
stix2slider/test/test_idioms.py 77.87% <100%> (+0.19%) :arrow_up:
stix2slider/convert_pattern.py 58.91% <56.72%> (+0.54%) :arrow_up:
stix2slider/convert_stix.py 66.12% <65.82%> (-0.36%) :arrow_down:
stix2slider/common.py 82.05% <69.23%> (+0.71%) :arrow_up:
stix2slider/convert_cyber_observables.py 73.04% <71.17%> (-0.47%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ff7ca9a...71ed0f3. Read the comment docs.

rpiazza commented 5 years ago

@clenk

If you review latest changes and merge this - I can do the release.