Closed aryabharat closed 6 months ago
@aryabharat - please merge in the master branch. It should allow the "checks" pass
@rpiazza I have update the branch.
There is a problem with the github actions - they are failing. I know what needs to be done, but I have to get the admin of the OASIS-OPEN repo to do it. Hopefully, we can get this done soon.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
0541655
) 73.40% compared to head (7613544
) 73.41%. Report is 4 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @aryabharat,
I think if you fix the pre-commit error below - I will be able to do the merge:
tox: pre-commit-check pre-commit-check: commands[0]> pre-commit run --all-files
trim trailing whitespace.................................................Passed check for merge conflicts................................................Passed Check project styling....................................................Failed
exit code: 1
stix2slider/convert_pattern.py:818:1: E302 expected 2 blank lines, found 1
Sort python imports (shows diff).........................................Passed Sort python imports (fixes files)........................................Passed
@aryabharat - nevermind - I will take care of it...
@aryabharat - nevermind - I will take care of it...
Thanks @rpiazza
Add URL type for convet_url function for stix 1.x
Reference issue: https://github.com/oasis-open/cti-stix-slider/issues/65