search

oasis-open / cti-stix-visualization

OASIS TC Open Repository: Lightweight visualization for STIX 2.0 objects and relationships
http://oasis-open.github.io/cti-stix-visualization
BSD 3-Clause "New" or "Revised" License
141 stars 43 forks source link

Relationship arrows not displaying in IE11 #27

Closed StephenThomson closed 6 years ago

StephenThomson commented 6 years ago

In IE11 the link arrows between nodes do not display correctly. If you update the stylesheet in developer tools they appear but remain in place if you move a node.

Also it is possible to drag nodes out of the canvas onto any section of the page.

gtback commented 6 years ago

Thanks, @StephenThomson. I'll have to dig up a Windows box to test this, but it's definitely something we should fix 😁

StephenThomson commented 6 years ago

Thanks Greg! Sorry to cause you to have do that. I wish I didn't have to support IE too :)

StephenThomson commented 6 years ago

Hi Greg,

Just wondering if there's any progress/plans on this issue?

If the answer is "go fix it yourself" I would completely understand! haha

Steve

gtback commented 6 years ago

Hi, @StephenThomson . No updates, sorry. If you have time and are able to fix this, it would be much appreciated! I'm not sure when we'll be able to do it ourselves.

gleithall commented 6 years ago

The lack of lines connecting the nodes is caused by a known issue for IE 10 and 11 relating to SVG paths not rendering when they have markers.

We have a fork of the code in which both the arrow heads and shafts are drawn using SVG paths, rather than using marker definitions. The only difference is that the whole arrows are the same colour, rather than the arrow heads being black and the arrow shafts being grey.

I can look to create a branch of the current codebase and submit a PR if this fix would be useful.

gtback commented 6 years ago

Hi @gleithall . We would welcome a PR! You'll need to sign the OASIS TC Open Repository Individual CLA before we can merge anything. Let us know if you have any concerns.

I'm not particularly worries about the different colors, but I'm not a UI expert :-)

StephenThomson commented 6 years ago

@gtback I believe we signed one as an organisation for a previous contribution. @gleithall I think you can fork into the CACI org, make your changes there then do a PR on behalf of CACI.

gtback commented 6 years ago

@StephenThomson you have a signed CLA on this page, but we need one from each person who is making commits that go into the repo. Thanks!

gleithall commented 6 years ago

@gtback I have created PR #31 for this issue. I have also signed the CLA.

gtback commented 6 years ago

Thanks, @gleithall. I think there's some background work at OASIS to confirm the CLA, but after that your PR should be good to merge!

gleithall commented 6 years ago

@gtback My CLA has now been processed, and appears on the page you referenced earlier.

gtback commented 6 years ago

Fixed by #31