search

oasis-open / cti-stix-visualization

OASIS TC Open Repository: Lightweight visualization for STIX 2.0 objects and relationships
http://oasis-open.github.io/cti-stix-visualization
BSD 3-Clause "New" or "Revised" License
138 stars 43 forks source link

Make email attachments show as a graph edge #50

Closed dwjohnston closed 2 years ago

dwjohnston commented 2 years ago

Solves #49

I haven't tested this for this particular as I can't see an easy way for to run the code locally (I don't have python, jupiter notebook setup) #42 would help in this regard (provide a way to run/test the code locally, with JavaScript/Node only).

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

chisholm commented 2 years ago

I can't see an easy way for to run the code locally (I don't have python, jupiter notebook setup) #42 would help in this regard (provide a way to run/test the code locally, with JavaScript/Node only).

It is trivial to run locally. Start your browser and open index.html directly from the filesystem. E.g. press Ctrl+O, in the file browser navigate to index.html. Using Node is actually more complicated than it needs to be. This is hinted at in the readme:

... is suitable for standalone use — either on a hosted server or as a local file ...

but it's not really spelled out in detail.

As far as adding new embedded relationships, as Chris has mentioned, we are in the process of changing graph libraries. When that is settled, then we can resume building upon it.

ejratl commented 2 years ago

The desired behaviour is now present the visualizer following the merge of PR#52. I don't think this fix is needed any more. @dwjohnston will you check the latest visualizer and confirm whether it meets your needs, please?

ejratl commented 2 years ago

@dwjohnston I believe that the issue that you were trying to address with this pull request has been fixed. I am therefore closing this issue. Please reopen it if you disagree.