search

oasis-open / cti-taxii-client

OASIS TC Open Repository: TAXII 2 Client Library Written in Python
https://taxii2client.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
107 stars 51 forks source link

Remove the extra space in the Content-Type #95

Closed 2xyo closed 3 years ago

2xyo commented 3 years ago

According to TAXII-2.1, there is no spaces between the media type and the version parameter : application/taxii+json;version=2.1.

This is not the case for TAXII-2.0 : application/vnd.oasis.taxii+json; version=2.0.

The section 3.1.1.1 of RFC7231, the following examples are all equivalent, but the first is preferred for consistency:

text/html;charset=utf-8
text/html;charset=UTF-8
Text/HTML;Charset="utf-8"
text/html; charset="utf-8"

Event if application/taxii+json;version=2.1 is equivalent to application/taxii+json; version=2.1, application/taxii+json;version=2.1 should be preferred.

emmanvg commented 3 years ago

Hi @2xyo, thanks for finding this! I think in the past you might have made contributions not related to functional code (documentation, configuration, etc.). This time around we might need you to sign the OASIS Individual CLA (https://www-legacy.oasis-open.org/resources/open-repositories/cla/individual-cla) in order to incorporate these changes. If you can't or don't want to, you can either close this PR or comment in this thread and I will incorporate these changes manually. Thanks!

2xyo commented 3 years ago

CLA accepted :)

emmanvg commented 3 years ago

Forgot to mention this, but you can review if your submission went through here (https://www-legacy.oasis-open.org/resources/open-repositories/cla/view-individual). I was checking but could not find an entry with your GitHub username. If you already submitted the form, and cannot view your entry in the link I added here let me know.

2xyo commented 3 years ago

Thanks @emmanvg , I Accepted the CLA on the website, then replied to the email from repository-cla@oasis-open.org (Wed, 10 Feb 2021 19:04:44 +0100) and the status of my demand is "approval pending" on https://www-legacy.oasis-open.org/node/5806