search

oasis-open / odata-rapid

Rapid - Specification, tools and libraries to support the development and adoption of simple REST-based APIs.
https://rapid.rocks
Apache License 2.0
16 stars 8 forks source link

Fix reference to dependencyinjection to #429

Closed mikepizzo closed 1 year ago

ralfhandl commented 1 year ago

I get a few warnings:

[warn]: OmniSharp.MSBuild.ProjectLoader
        Microsoft.Extensions.DependencyInjection.Abstractions 7.0.0 doesn't support netcoreapp3.1 and has not been tested with it. Consider upgrading your TargetFramework to net6.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk.
[warn]: OmniSharp.MSBuild.ProjectLoader
        Microsoft.Extensions.DependencyInjection 7.0.0 doesn't support netcoreapp3.1 and has not been tested with it. Consider upgrading your TargetFramework to net6.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk.
[warn]: OmniSharp.MSBuild.ProjectLoader
        JetsonsReadWrite depends on Microsoft.Extensions.DependencyInjection (>= 6.1.0) but Microsoft.Extensions.DependencyInjection 6.1.0 was not found. An approximate best match of Microsoft.Extensions.DependencyInjection 7.0.0 was resolved.
ralfhandl commented 1 year ago

Probably caused by https://github.com/oasis-open/odata-rapid/blob/3d1ad12bf4e358e14b193001816e6663fdbbd278/samples/Jetsons/Jetsons/Jetsons.csproj#L4

ralfhandl commented 1 year ago

I think the files in folder .vs should not be checked in, and .vs should be added to .gitignore, they are probably config/settings for Visual Studio Classic

mikepizzo commented 1 year ago

I think the files in folder .vs should not be checked in, and .vs should be added to .gitignore, they are probably config/settings for Visual Studio Classic

Yes; these were accidentally brought in when I tried to resolve conflicts in updating the .net framework. They have been fixed

ralfhandl commented 1 year ago

Found two more occurrences of netcoreapp3.1, changed them to net7.0:

After deleting all bin and obj folders and rebuilding the Jetsons app launches and works as expected.

ralfhandl commented 1 year ago

Still haven't figured out how to launch JetsonsReadWrite 😦

mikepizzo commented 1 year ago

Found two more occurrences of netcoreapp3.1, changed them to net7.0:

  • samples/Jetsons/.vscode/launch.json
  • samples/Jetsons/Microsoft.Restier.Providers.InMemory/Microsoft.Restier.Providers.InMemory.csproj

After deleting all bin and obj folders and rebuilding the Jetsons app launches and works as expected.

Good catch -- thanks!